Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLANG-1212] Add content_type parameter for POST artifact.json API call #155

Merged
merged 14 commits into from Apr 11, 2022

Conversation

imrekel
Copy link
Contributor

@imrekel imrekel commented Apr 2, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Added passing the artifact's content type to the Monolith's API via the content_type parameter.
This is required to support GCS artifact storage as signed URL's of GCS must be generated using the same content-type that is used during uploads to the URL.

@imrekel imrekel marked this pull request as ready for review April 11, 2022 11:28
@imrekel imrekel merged commit addc2a7 into bitrise-steplib:master Apr 11, 2022
@imrekel imrekel deleted the content-type-api branch April 11, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants