Override API connection via step inputs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
reviewed
Aug 11, 2022
| @@ -205,13 +211,19 @@ func (s Step) createCodesignManager(inputs Inputs, xcodeMajorVersion int) (codes | |||
|
|
|||
| var serviceConnection *devportalservice.AppleDeveloperConnection = nil | |||
| devPortalClientFactory := devportalclient.NewFactory(s.logger) | |||
| if authType == codesign.APIKeyAuth || authType == codesign.AppleIDAuth { | |||
| if inputs.BuildURL != "" && inputs.BuildAPIToken != "" { | |||
There was a problem hiding this comment.
Could still skip creating connection if authType is off.
There was a problem hiding this comment.
The "off" option is handled at the beginning of createCodesignmanager(). In fact this whole function is not called if automatic code signing is off.
lpusok
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Enables overriding App Store Connect API connection through step inputs.
go-xcode PR: bitrise-io/go-xcode#184
Changes
go-xcodeInvestigation details
Decisions