Retry on http status unauthorized #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
reviewed
Sep 18, 2023
| @@ -1,18 +1,36 @@ | |||
| module github.com/bitrise-steplib/steps-google-play-deploy | |||
|
|
|||
| go 1.16 | |||
| go 1.20 | |||
There was a problem hiding this comment.
I think I have asked this question in someone else's PR already but I do not remember the answer and could not find which PR it was.
The default go on our stacks is 1.18 and here we are defining a more recent version. The tests pass and everything looks fine so it does not cause a problem right but technically this value should point the minimum version the app is compatible I think. So just want to double check that this is fine here.
There was a problem hiding this comment.
It does not cause issues in this case, it will still work with 1.18. However in and after go 1.21, go runtime takes extra steps to use the defined go version, so will have to be more careful.
ofalvai
reviewed
Sep 18, 2023
tothszabi
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
Similar workaround to fastlane/fastlane#21507 (comment).
Retry HTTP calls when 401 is (randomly) returned by Google, that causes customer impact.
Retry working: https://app.bitrise.io/build/065421cb-2e6f-4f0d-acd8-44035136eb07
Changes
Investigation details
Decisions