Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .ipa input optional when .dSYM is given #24

Merged
merged 1 commit into from Jul 3, 2017
Merged

Make .ipa input optional when .dSYM is given #24

merged 1 commit into from Jul 3, 2017

Conversation

MiloszFilimowski
Copy link
Contributor

According to API documentation it is possible to upload an app without .ipa if .dSYM is given. This helps when using HockeyApp only for crash reporting.

This PR introduces a small change to allow for dsym_path to be passed without ipa_path

@viktorbenei
Copy link
Contributor

Thanks for the PR @MiloszFilimowski ! We'll review this ASAP! :)

@viktorbenei
Copy link
Contributor

Just a quick note until the review: you can use your own version of this step with the git:: style reference (http://devcenter.bitrise.io/bitrise-cli/steps/#special-step-sources):

Instead of:

    steps:
    - hockeyapp-deploy:

use:

    steps:
    - git::https://github.com/MiloszFilimowski/steps-hockeyapp-deploy.git@optional-ipa:

@MiloszFilimowski
Copy link
Contributor Author

Thanks @viktorbenei ;)

@viktorbenei
Copy link
Contributor

Any time @MiloszFilimowski ;)

@godrei
Copy link
Contributor

godrei commented Jul 3, 2017

Hi @MiloszFilimowski ,
thanks for the PR, your changes looks great to me!

@godrei godrei merged commit 541f4f5 into bitrise-steplib:master Jul 3, 2017
@MiloszFilimowski MiloszFilimowski deleted the optional-ipa branch July 22, 2017 17:54
@MiloszFilimowski MiloszFilimowski restored the optional-ipa branch July 22, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants