Update

[godrei]

No description provided.

[gaborszakacs]

Pls describe the method that is under test, and drop the it from the test case description, the subject will be the method you described.

describe '.ensure_test_devices' do
  it 'registers new device' do
...

[gaborszakacs]

What's our expectation here? Only that no error will be raised?

[godrei]

yepp, this test failes if you revert this line change: https://github.com/bitrise-steplib/steps-ios-auto-provision/pull/22/files#diff-a8717d4d6fa7414f7c105f8c475b9971R29

[gaborszakacs]

Consider using the describe block and contexts here too and DRYing up the tests with one-liners.

RSpec.describe 'ProjectHelper' do
  let(:project_with_target_attributes) do
    path = File.join(test_project_dir, 'foo.xcodeproj')
    project = Xcodeproj::Project.open(path)
    recreate_shared_schemes(project)
    project
  end

  let(:project_without_target_attributes) do
     project = project_with_target_attributes
     project.root_object.attributes['TargetAttributes'] = nil
     project.save
     project
  end

  describe '#uses_xcode_auto_codesigning?' do
    subject { ProjectHelper.new(project.path, 'foo', '').uses_xcode_auto_codesigning? }

    context 'when new Xcode project uses auto signing with TargetAttributes' do
      let(:project) { project_with_target_attributes }
      it { is_expected.to eq true }
    end

    context 'when new Xcode project uses auto signing without TargetAttributes' do
      let(:project) { project_without_target_attributes }
      it { is_expected.to eq true }
    end
  end
end

[gaborszakacs]

Tests still pass without using the hash as a fallback, I think, they shouldn't.

[gaborszakacs]

🚜 👍