Step cleanup #43
Step cleanup #43
Conversation
| if cfg.ForceTeamID != "" { | ||
| log.Printf("Forcing Development Team: %s", cfg.ForceTeamID) | ||
| archiveCmd.SetForceDevelopmentTeam(cfg.ForceTeamID) | ||
| customOptions = append(customOptions, fmt.Sprintf("DEVELOPMENT_TEAM=%s", cfg.ForceTeamID)) |
There was a problem hiding this comment.
These are no longer supported in go-xcode because we decided to deprecate these input options in the iOS steps, but I'd rather not remove these inputs from this step and cause a breaking change.
| @@ -459,7 +461,7 @@ The log file is stored in $BITRISE_DEPLOY_DIR, and its full path is available in | |||
| log.Donef("The xcarchive path is now available in the Environment Variable: %s (value: %s)", bitriseXCArchiveDirPthEnvKey, archivePath) | |||
|
|
|||
| if cfg.IsExportXcarchiveZip == "yes" { | |||
| if err := output.ZipAndExportOutput(archivePath, archiveZipPath, bitriseXCArchivePthEnvKey); err != nil { | |||
| if err := output.ZipAndExportOutput([]string{archivePath}, archiveZipPath, bitriseXCArchivePthEnvKey); err != nil { | |||
There was a problem hiding this comment.
Breaking change in go-xcode, the function now expects a string slice
| @@ -738,7 +740,7 @@ is available in the $BITRISE_IDEDISTRIBUTION_LOGS_PATH environment variable (val | |||
| log.Infof("Exporting dSYM files ...") | |||
| fmt.Println() | |||
|
|
|||
| appDSYM, frameworkDSYMs, err := archive.FindDSYMs() | |||
| appDSYMs, frameworkDSYMs, err := archive.FindDSYMs() | |||
There was a problem hiding this comment.
Breaking change in go-xcode, now returns two string slices
e2e/bitrise.yml
Outdated
| - is_export_xcarchive_zip: "yes" | ||
| - export_method: $EXPORT_METHOD | ||
| - verbose_log: "yes" | ||
| - script: |
There was a problem hiding this comment.
Use https://github.com/bitrise-steplib/bitrise-step-check-step-outputs if possible.
| before_run: | ||
| - _common | ||
|
|
||
| test_copy: |
There was a problem hiding this comment.
Do we need app-store without profile and developer ID tests?
e2e/bitrise.yml
Outdated
|
|
||
| app: | ||
| envs: | ||
| - SAMPLE_APP_URL: https://github.com/bitrise-io/macos-sample-app.git |
There was a problem hiding this comment.
Let's use TEST_APP_URL for consistency with other Step.
e2e/bitrise.yml
Outdated
| app: | ||
| envs: | ||
| - SAMPLE_APP_URL: https://github.com/bitrise-io/macos-sample-app.git | ||
| - BITRISE_PROJECT_PATH: macos-sample-app.xcodeproj |
There was a problem hiding this comment.
Same as above, use TEST_APP_URL.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
Clean up step and its E2E tests before making other changes
Changes
e2e/bitrise.ymlgo-xcodein particular with this fix: Fix parsing of macOS profile types bitrise-io/go-xcode#159go-xcodeandgo-utilsfindIDEDistrubutionLogsPath()Investigation details
Decisions