Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected output variable and filename of raw output log #313

Merged
merged 4 commits into from Dec 19, 2022
Merged

Conversation

vshah23
Copy link
Contributor

@vshah23 vshah23 commented Dec 15, 2022

Checklist

  • I've read and followed the Contribution Guidelines
  • step.yml and README.md is updated with the changes (if needed)

Version

Requires a PATCH version update

Context

Users were confused when looking for raw-xcodebuild-output.log in their build artifacts.

Changes

Updated the messages to indicate the correct env var and file name

Investigation details

The expected file was not referenced anywhere in the code base. In fact the raw build output was instead being saved as xcodebuild-archive.log and xcodebuild-export-archive.log in the case of archive for ipa export.

Decisions

Updated the env var name and file name of the raw log output in the console messaging.

@godrei
Copy link
Contributor

godrei commented Dec 16, 2022

Looks good to me 👍

@vshah23 vshah23 merged commit 2b0843e into master Dec 19, 2022
@vshah23 vshah23 deleted the CI-404 branch December 19, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants