Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hash (#) from routing #16

Closed
1 of 2 tasks
moebiusmania opened this issue Sep 18, 2018 · 1 comment
Closed
1 of 2 tasks

remove hash (#) from routing #16

moebiusmania opened this issue Sep 18, 2018 · 1 comment
Assignees
@moebiusmania
Labels
Priority: Low Status: Available Type: Enhancement
Milestone
v1.3

Comments

@moebiusmania
Copy link
Contributor

moebiusmania commented Sep 18, 2018 •
edited
Loading

After resolving #2 , we can remove the hash from the routing and use the pushStateAPI, so we can resolve urls like https://bitrock.it/academy

  • remove useHash: true from Router5 conf
  • ~~~add a 404.html file which will be a copy of index.html ~~~
@moebiusmania moebiusmania added this to the v1.3 milestone Sep 18, 2018
@moebiusmania moebiusmania self-assigned this Sep 18, 2018
moebiusmania added a commit that referenced this issue Sep 18, 2018
@moebiusmania
switched to webpack-dev-server (again), add management of both hash a…
e706607 
…nd non-hash routing (related to #16)
@moebiusmania
Copy link
Contributor Author

moved from router5 to @vaadin/router, and solved this issue as a consequence.

@moebiusmania moebiusmania mentioned this issue Sep 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moebiusmania moebiusmania

Labels
Priority: Low Status: Available Type: Enhancement
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
1 participant
@moebiusmania