-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitbucket Server support? #2
Comments
this would require some code changes and some new test. https://github.com/drone/go-scm can handle all provides that drone uses. i you or someone else wants do do the changes, i am happy to merge them. |
I forked this repository to attempt the changes myself. I have no previous experience with golang, but it seems like we are going to hit a wall with
Missing API calls
The first is a call to
The second is more troublesome, in that the call to I worry that adding the above two API calls to |
I would be ok with it if we can abstract the provider to an interface. That way it should be easy to add new providers afterwards. For now we would have just a bitbucket and a github provider. Users that require more would be able to add them. Thanks for taking the time! |
Thanks, I'll do my best to find the time for that! Regarding the first API call, is there a difference between (This is assuming that Edit: also made an issue in go-scm for long term improvement. |
If i remind correctly: if one pushes multiple commits |
I managed to extract a common interface and finish an implementation with BitBucket support. I'll test it over the next few days and send a PR. It's quite a big change due to SCM-specific code having to be separated. It is fully backwards compatible with one exception, I thought it better to rename the The following environment variables need to be passed to drone-tree-config to add BitBucket support:
You can use the same client credentials as you use for drone-master. |
Hey @Oduig, awesome! I will have a detailed look and test against our infrastructure in the next few days. Thanks for taking time! |
Is there a way for this to work on Bitbucket Server?
The text was updated successfully, but these errors were encountered: