Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mat3x4 #156

Closed
wants to merge 1 commit into from
Closed

WIP: Mat3x4 #156

wants to merge 1 commit into from

Conversation

emilk
Copy link
Contributor

@emilk emilk commented Apr 1, 2021

Part of #25

This was more work than I thought (it always is). I can't say I fully grok how all the different traits fit together, but I tried to copy the basic structure of the 4x4 types. I still have some hard-to-decipher errors.

TODO:

  • Get it to compile
  • Finish up the TODO:s an commented code
  • Write tests
  • Write benchmarks

@bitshifter
Copy link
Owner

Thanks for that, I haven't had a chance to have a proper look yet, hopefully I'll find some time over the long weekend. It might pay to flesh things using the public types and look at the core stuff later. It is a bit complicated unfortunately and I haven't had to think about how to deal with new types yet.

@emilk
Copy link
Contributor Author

emilk commented Apr 2, 2021

No hurry - I (probably) won't continue work on this until Tuesday. And yeah, I should have started with

struct Mat3x4 {
    x_row: Vec4,
    y_row: Vec4,
    z_row: Vec4,
}

I might make another PR with that so we can try that out and do benchmarks etc.

@emilk emilk mentioned this pull request Apr 6, 2021

/// Creates a 3x4 matrix from threw row vectors.
#[inline(always)]
pub fn from_rows(x_row: $vec4, y_row: $vec4, z_row: $vec4) -> Self {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be $vec3

@emilk
Copy link
Contributor Author

emilk commented Apr 7, 2021

Closed in favor of #157

@emilk emilk closed this Apr 7, 2021
@khyperia khyperia deleted the mat3x4 branch June 1, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants