Add support for infinite projection matrices #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both standard and reverse depth. The infinite reverse projection matrix is the only one we use, and it is the one with the best precision and the simplest construction. So really the one most everyone should use by default. Probably should rename the perspective_glu function here also, or maybe (depending on how opionated we want to be) simply remove it? It is only useful in OpenGL due to the -1,1 depth range and it should have a `_rh` suffix to indicate it is right-handed.
26 tasks
|
Thanks. The main driver for unit tests is ensuring the SIMD and scalar code behaves the same, so shouldn't matter too much here, other than keeping code coverage happy... |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both standard and reverse depth.
The infinite reverse projection matrix is the primary one we use, and it is the one with the best precision and the simplest construction. So really the one most everyone should use by default.
Difficult to unit test this, but multiple of us have verified the construction of it.
Also probably should rename the
perspective_glufunction here also, or maybe (depending on how opinionated we want to be) simply remove it? It is only useful in OpenGL due to the -1,1 depth range and it should have a_rhsuffix to indicate it is right-handed.