Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider.request (tested with "personal_sign") returned promise do not resolve when user close the popup #475

Open
wighawag opened this issue Feb 24, 2024 · 1 comment

Comments

@wighawag
Copy link

Describe the bug
provider.request (tested with "personal_sign") returned promise do not resolve when user close the popup

To Reproduce

const signature = await provider.request({
	method: 'personal_sign',
	params: [account, 'hello']
});
// never reach there when user close the popup
console.log({signature})

See repo : https://github.com/bug-reproduction/bitski-request-no-resolved

Expected behavior
I expect request to always resolve after user action, else we cannot act on its rejection

SDK:

  • Version 4.2.0
@pzuraq
Copy link
Collaborator

pzuraq commented Mar 1, 2024

Hi there, thank you for the bug report! I'll take a look at this once I have time, but I did just merge some changes which may fix this issue, I'll get those released soon so you can test it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants