Skip to content

Commit

Permalink
Correct Mysql README + potential fix for UseBiasedLocking (#42)
Browse files Browse the repository at this point in the history
* Fixed typos README.md

Fixed exec command in README

* Fixed jvm.config

Removed UseBiasedLocking, as it resulted with invalid parameter which caused the trino-coordinator to crash.
Also relates to issue: #41
  • Loading branch information
SirNatan1 committed Mar 28, 2024
1 parent 07051c1 commit ce3b5dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion mysql/trino-mysql/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ container. Notice the container id is `trino-mysql_trino-coordinator_1` so the
command you will run is:

```
docker container exec -it trino-mysql_trino-coordinator_1 trino
docker container exec -it trino-mysql-trino-coordinator-1 trino
```

When you start this step, you should see the `trino` cursor once the startup
Expand Down
3 changes: 1 addition & 2 deletions mysql/trino-mysql/etc/jvm.config
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
-server
-Xmx1G
-XX:-UseBiasedLocking
-XX:+UseG1GC
-XX:G1HeapRegionSize=32M
-XX:+ExplicitGCInvokesConcurrent
Expand All @@ -9,4 +8,4 @@
-XX:+ExitOnOutOfMemoryError
-XX:ReservedCodeCacheSize=256M
-Djdk.attach.allowAttachSelf=true
-Djdk.nio.maxCachedBufferSize=2000000
-Djdk.nio.maxCachedBufferSize=2000000

0 comments on commit ce3b5dc

Please sign in to comment.