Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing input fields to support Monero #392

Closed
ManfredKarrer opened this issue Apr 22, 2016 · 2 comments
Closed

Add missing input fields to support Monero #392

ManfredKarrer opened this issue Apr 22, 2016 · 2 comments

Comments

@ManfredKarrer
Copy link
Member

To support Monero we need to add extra fields to the altcoin address:
Here is the information gathered in a IRC conversation:

[18:39:33]  <palexander>         Trying to get Monero added to BitSquare.  This is the reply I received:
[18:39:49]  <palexander>         palexander: i would love to and talked to them, but unfortunately its not possible yet. with monero you cannot see the receivers address in the block explorer so the arbitrator could not verify that the altcoins have been paid in case of a dispute. they have technically a possibility to add a feature to make it possible but its not implemented yet.
[18:39:56]  <palexander>         Cant we just use a payment id?
[18:42:49]  <dEBRUYNE>   use the tx key
[18:43:07]  <dEBRUYNE>   the tx key is mainly used to settle disputes
[18:43:24]  <dEBRUYNE>   mainly useful for settling*
[18:43:56]  <palexander>         So a third party can arbitrate with the tx key?
[18:44:22]  <dEBRUYNE>   Yes, afaik
[18:44:26]  <dEBRUYNE>   lemme search it
[18:45:19]  <dEBRUYNE>   palexander: https://bitcointalk.org/index.php?topic=753252.msg12083138#msg12083138
[18:46:58]  <palexander>         Is that functionality available now though?
[18:47:49]  <dEBRUYNE>   yes
[18:47:59] dEBRUYNE      grabs some food and will explain in a bit
[18:49:59]  <dEBRUYNE>   palexander: So it works as follows iirc. The wallet cache stores all the tx keys. Thus, with simplewallet you will be able to retrieve all tx keys and which specifically belong to a certain transaction
[18:50:11]  <palexander>         alright...I gotta head to bed though.  Maybe toss the idea around and contact Manfred in #bitsquare
[18:50:11]  <dEBRUYNE>   There is a command for that, use ¨help¨ to see which one it precisely is
[18:50:25]  <dEBRUYNE>   If you have the tx key, you can plug it in at luigi1111w´s tool
[18:50:34]  <dEBRUYNE>   http://xmr.llcoins.net/checktx.html
[18:50:44]  <dEBRUYNE>   so you give the tx key and the transaction ID to the third party
[18:50:57]  <dEBRUYNE>   the third party plugs in the tx key, transaction ID, and the receiver´s address
[18:51:05]  <dEBRUYNE>   and that will show if Alice really made the transaction to Bob
[18:51:22]  <dEBRUYNE>   <palexander> alright...I gotta head to bed though.  Maybe toss the idea around and contact Manfred in #bitsquare <= I g2g in a bit, you could save this and use it for later
[18:51:58]  <palexander>         ok, Ill save it.  I guess Manfred of BitSquare is going to chat with fluffypony as well at some convention in May.

dEBRUYNE
the third party plugs in the tx key, transaction ID, and the receiver´s address
dEBRUYNE
and that will show if Alice really made the transaction to Bob
dEBRUYNE
alright...I gotta head to bed though. Maybe toss the idea around and contact Manfred in #bitsquare <= I g2g in a bit, you could save this and use it for later
palexander
ok, Ill save it. I guess Manfred of BitSquare is going to chat with fluffypony as well at some convention in May.
dEBRUYNE
all right
palexander
Thanks for the info dEBRUYNE , I passed it along to Manfred.
dEBRUYNE
you´re welcome :)
yeswepump
!balance
tippero
yeswepump's balance is 752,704 piconero (7.52704e-07 Monero)
19:26 moneromooo
palexander: one caveat is that sender must ensure the txkey is saved. Remove your wallet cache and it's gone.
moneromooo
But it does work, I tried it just a few days ago IIRC.
moneromooo goes ddg bitsquare
janko33
!balance
tippero
janko33's balance is 100.671140939 millinero (0.100671140939 Monero)
mkarrer
dEBRUYNE, moneromooo, palexander: I will have a look asap into the new simple wallet to check out how monero can be added to Bitsquare. I would love to get it into the Beta...
moneromooo
mkarrer: two things to check out start with: get_tx_key command in simplewallet, and the get_tx_key boolean in the transfer RPC.
moneromooo
Need to have set store-tx-info enabled in the wallet for the key to get saved, but it's on by default except for wallets made a short while after I coded it.
othe
mkarrer does bitsquare require bitcoin scripts to work?
mkarrer
moneromooo: thanks i will check it out soon, will prob. come back then when i have questions
moneromooo
Sure.
mkarrer
othe: bitsquare has alway sbitcoin on one side of the trade. btc-fiat or btc-altcoin. on the btc side it use 2of3 MS.

@ManfredKarrer
Copy link
Member Author

Integrated now Monero support into Bitsquare.
It was not needed to add extra input fields just a popup with the info regarding the requirements.
Those are:

  • Use simplewallet no other wallets
  • have store-tx-info flag enabled
  • be sure that you can access the tx key with get_tx_key command in simplewallet
  • no payment ID needed, just normal public address

In case of a dispute the XMR sender needs to provide those data to the arbitrator:

  • The tx private key
  • The transaction hash
  • The recipient's public address

The arbitrator use those data to check with the checktx tool (http://xmr.llcoins.net/checktx.html) if the XMR was sent. A normal block explorer is not sufficient.

@ManfredKarrer
Copy link
Member Author

ManfredKarrer commented May 25, 2016

Here the popup displayed when saving a monero account:

bildschirmfoto 2016-05-25 um 12 37 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant