This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
3f47a78
commit e55a375
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e55a375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be switched to using the API level instead (
Build.VERSION.SDK_INT
)? That way there wouldn't need to be an update to the HockeySDK for every new preview build of the Android OSe55a375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mark,
thanks for the tip. Since we get the minimum required OS version as a string like "5.0" and not an API level from the HockeyApp API we would then have to maintain a mapping of versions to API levels and update this with every new (even minor) release.
e55a375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matthias,
I see. If the data for API level isn't there in the API, what would you think of flipping the fallback behavior? For example: the SDK could consider a version letter to always be newer than a version number. It seems unlikely that a preview build will ever be too old. We test our app on preview builds, and the current behavior makes it harder for us to keep betas up to date every time a new Android version preview comes out
e55a375
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mark,
I agree, just created #72 for this. Appreciate any feedback.
Unfortunately at least this time you will have to update the SDK one more time to get this fix once it's out.
Best,
Mat