can't find referenced class org.apache.http.* #80
Comments
|
Thanks for pointing this out. We're already working on this and other changes necessary for Android 6.0 - see #77. |
|
This should be a high priority issue, because including the legacy library is no small thing when APK size is considered (2MB after proguard 😨) |
|
One more to add to @the4thfloor's list:
|
|
Thanks @hzsweers as well. Let me clarify: We are not aiming at targeting the legacy library but replacing the mentioned code with either |
|
I figured, just explaining why the legacy library wasn't the best option either :) Volley will give you the same problems for the time being unfortunately since it also uses apache stuff under the hood. HttpUrlConnection seems like the minimal impact route, but if you're open to using a library, I'd recommend using OkHttp. It's what powers UrlConnection on Lollipop+, and is pretty widely used. Add in its modernity, robustness, and nice API, I'd say it's worth it. I'd even offer to do the pull request myself if you're open to it! |
|
Thanks for the suggestion of OkHttp - but it requires Android 2.3 minimum and I'm not quite sure we're ready for that. API looks good, though. |
|
Why not? Using 2.3 as a minimum covers 99.7% of all devices. If that's not For reference: On Sat, Aug 22, 2015, 4:10 PM Mat notifications@github.com wrote:
|
|
But if it depends on OkHttp all projects depend on it too :-( |
|
That's true, but it might be worth the tradeoff. I only suggested it since @ranterle seemed open to using another library by mentioning Volley. OkHttp has a fairly minimal footprint. Its classes.dex is only 300kB, and that would only get smaller with proguard. |
|
We're not only looking for Android versions on Google Play in that regard, that's why I'm not sure to say we can go 2.3 minimum. |
|
Where else are you looking? Google Play should be a fairly optimistic On Sun, Aug 23, 2015, 5:52 AM Mat notifications@github.com wrote:
|
|
We will not add dependencies which all projects using our SDK will also have to adopt. If you are doing something like that in an internal library, this might be ok to do, but not in an SDK that is used in thousands of applications. We will fix the warnings as soon as possible. |
|
Then don't. I chimed in about OkHttp because @ranterle suggested Volley as an option, so it was fair to assume at the time that 3rd party options were ok. When he said 2.3 wasn't a viable minimum, and that you don't use Google's OS version statistics, I was curious to find out why. Your comment felt both dismissive and condescending. You preach good SDK maintanance, but this SDK has limped along for some time now with minimal work (handful of commits/month). On top of this, it runs into the same issues again and again while barely ever releasing fixes for them. Last year you didn't have a Lollipop-compatible release until several months (December) after its release. The exact same thing happened this year with the M preview. Now you're breaking builds because you didn't address something that was announced months ago. It's frustrating for developers that depend on your SDK, and to see how dismissive you were in your comment for merely discussing solutions in your issue tracker is disappointing to see. This isn't to knock the two primary maintainers, they've both been helpful when I've contributed in the past. However, this comes across as a part time project with no full time maintainers. Your iOS SDK is very well maintained and updated often, why can't Android get the same level of attention? |
|
Thanks for the feedback, we definitely appreciate it. We released a new version of our Android SDK just yesterday, see here: Both our iOS and Android SDK are currently in beta and our philosophy is that we won't release a final version before Apple and Google have announced the respective final version of their OS. In 2014, our Android SDK got significantly less feedback than our iOS SDK while many customers had a hard requirement on supporting old Android versions. My impression is that this has recently changed with more pull requests, open & closed issues, and a more open communication (like your feedback above). We are definitely commited to the Android community and plan to ship the final release of 3.6 soon as well as another major release later this year. |
|
3.6.0 was released yesterday (blog post coming up), closing this. |
|
@ranterle This seems to be no longer working https://stackoverflow.com/a/50779232/2563009. |
|
The hockey SDK removed apache http client a long time ago and is using URLConnection directly now so this stack overflow link does not apply to the current version of the SDK. |
With Android M / 6 the Apache HTTP stuff is gone but the SDK uses it a lot.
It can be fixed with
but I prefer a cleaner way without dependencies to a deprecated lib :-)
The text was updated successfully, but these errors were encountered: