This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Release/1.0.1 hockeysdk androidsdk #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Aug 23, 2018
| compile 'com.android.support:appcompat-v7:27.0.2' | ||
| testCompile 'junit:junit:4.12' | ||
| implementation fileTree(dir: 'libs', include: ['*.jar']) | ||
| implementation 'com.android.support:appcompat-v7:28.0.0-rc01' |
There was a problem hiding this comment.
Unfortunately there’s no 28th stable version of appcompat yet. And we can not (should not because of warning) use 27.* verstion of appcompat with 28 Android SDK
SergeySmolin
approved these changes
Aug 23, 2018
sergey-akhalkov
approved these changes
Aug 23, 2018
ElektrojungeAtWork
suggested changes
Aug 23, 2018
ElektrojungeAtWork
approved these changes
Aug 23, 2018
|
Merging this, the stable version of 28 hasn't been released yet, I don't want to block this because of this |
matthiaswenz
approved these changes
Aug 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.