Initial implementation of WinForms HockeyApp SDK #78

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
3 participants
@dkackman
Contributor

dkackman commented Nov 9, 2016

#64

Squashed commit of the following:

commit 24ff7fb
Author: Don Kackman dkackman@gmail.com
Date: Tue Nov 8 20:27:03 2016 -0600

remove unused file

commit 63c0e53
Author: Don Kackman dkackman@gmail.com
Date: Tue Nov 8 20:24:02 2016 -0600

replace IsolatedStorage with standard System.IO file handling

commit 0c38c7e
Author: Don Kackman dkackman@gmail.com
Date: Tue Nov 8 19:46:16 2016 -0600

Since a winforms app doesn't have a built in IDictionary based settings collection allow these to be passed in during config setup

commit 5816e1a
Author: Don Kackman dkackman@gmail.com
Date: Tue Nov 8 19:45:01 2016 -0600

check if storeSessionEnd is already a DateTimeOffset before attempting to cast to string and parsing (this to support application settings dictionary serialized by json.net in a winforms app)

commit 1e701ba
Author: Don Kackman dkackman@gmail.com
Date: Mon Nov 7 21:13:51 2016 -0600

cleaning

commit 39b3296
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 21:31:12 2016 -0600

implement ReadConfigurationXml

commit 6164c4b
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 21:05:34 2016 -0600

base telemetry working with addtion of platform specific storage class (using IsolatedStorage) and HttpService

commit c808393
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 17:57:40 2016 -0600

add DeviceService (stub HttpService too)

commit d0d688a
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 15:59:32 2016 -0600

Add ApplicationService and configuation method

commit f7b4901
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 14:45:00 2016 -0600

add hardwareinfo (for manufacturer and model)
add debuginfo

commit 58391b7
Author: Don Kackman dkackman@gmail.com
Date: Sun Nov 6 14:07:04 2016 -0600

changes to get crash reporting owrking
- GetEntryAssembly
- PlatformService
Initial implementation of WinForms HockeyApp SDK
#64

Squashed commit of the following:

commit 24ff7fb
Author: Don Kackman <dkackman@gmail.com>
Date:   Tue Nov 8 20:27:03 2016 -0600

    remove unused file

commit 63c0e53
Author: Don Kackman <dkackman@gmail.com>
Date:   Tue Nov 8 20:24:02 2016 -0600

    replace IsolatedStorage with standard System.IO file handling

commit 0c38c7e
Author: Don Kackman <dkackman@gmail.com>
Date:   Tue Nov 8 19:46:16 2016 -0600

    Since a winforms app doesn't have a built in IDictionary based settings collection allow these to be passed in during config setup

commit 5816e1a
Author: Don Kackman <dkackman@gmail.com>
Date:   Tue Nov 8 19:45:01 2016 -0600

    check if storeSessionEnd is already a DateTimeOffset before attempting to cast to string and parsing (this to support application settings dictionary serialized by json.net in a winforms app)

commit 1e701ba
Author: Don Kackman <dkackman@gmail.com>
Date:   Mon Nov 7 21:13:51 2016 -0600

    cleaning

commit 39b3296
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 21:31:12 2016 -0600

    implement ReadConfigurationXml

commit 6164c4b
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 21:05:34 2016 -0600

    base telemetry working with addtion of platform specific storage class (using IsolatedStorage) and HttpService

commit c808393
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 17:57:40 2016 -0600

    add DeviceService (stub HttpService too)

commit d0d688a
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 15:59:32 2016 -0600

    Add ApplicationService and configuation method

commit f7b4901
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 14:45:00 2016 -0600

    add hardwareinfo (for manufacturer and model)
    add debuginfo

commit 58391b7
Author: Don Kackman <dkackman@gmail.com>
Date:   Sun Nov 6 14:07:04 2016 -0600

    changes to get crash reporting owrking
    - GetEntryAssembly
    - PlatformService
@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Nov 9, 2016

Hi @dkackman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

msftclas commented Nov 9, 2016

Hi @dkackman, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Nov 9, 2016

@dkackman, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

msftclas commented Nov 9, 2016

@dkackman, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@msftclas msftclas added cla-signed and removed cla-required labels Nov 9, 2016

@izikl

This comment has been minimized.

Show comment
Hide comment
@izikl

izikl Nov 22, 2016

Contributor

We never really worked on the WinForms SDK, the code that is in there today was created by the community and we kept it.

We are accepting your changes without any validation, as a way to share it with the community.

As a reference for other developers, could you please elaborate on the status of the SDK after your changes. including what tests (even if they are manual only) you have performed.

We will try to be clearer in the documentation about the status of the WinForms SDK.

Can you please re-create you PR against develop.
To keep you change isolated from other SDKs, can you please revert your change in Src/Kit.Core45/UserMetrics/SessionTelemetryModule.cs?

Contributor

izikl commented Nov 22, 2016

We never really worked on the WinForms SDK, the code that is in there today was created by the community and we kept it.

We are accepting your changes without any validation, as a way to share it with the community.

As a reference for other developers, could you please elaborate on the status of the SDK after your changes. including what tests (even if they are manual only) you have performed.

We will try to be clearer in the documentation about the status of the WinForms SDK.

Can you please re-create you PR against develop.
To keep you change isolated from other SDKs, can you please revert your change in Src/Kit.Core45/UserMetrics/SessionTelemetryModule.cs?

@dkackman

This comment has been minimized.

Show comment
Hide comment
@dkackman

dkackman Nov 23, 2016

Contributor

Closing this PR
New PR against develop branch created.
#81

Contributor

dkackman commented Nov 23, 2016

Closing this PR
New PR against develop branch created.
#81

@dkackman dkackman closed this Nov 23, 2016

@dkackman dkackman deleted the dkackman:preseason branch Nov 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment