Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Implemented core functionality for WPF #88

Closed
wants to merge 13 commits into from

Conversation

edoust
Copy link

@edoust edoust commented Nov 29, 2016

This pull request contains a stable implementation of the HockeySDK features for WPF:

  • Crash reports (including method metadata tokens, IL offsets, assembly signature and age values - in combination, a lookup of the original source code lines is possible)
  • Session telemetry
  • Custom Events

The other telemetry works too (e.g. page views, exceptions, etc.) but I did not thoroughly test that

Attachments
Sample CrashReport

@izikl
Copy link
Contributor

izikl commented Nov 29, 2016

@edoust thank you for your contribution, it looks good to me. One minor comment inline.
About testing:
On which OSs have you tested this code?

@edoust
Copy link
Author

edoust commented Nov 30, 2016

@izikl thanks for the feedback. I tested the code on Windows 7 and Windows 8.1 (inside a virtual machine). All areas of the crash reports are filled with the correct information

@darvell
Copy link

darvell commented Dec 23, 2016

Any timeline on this being pulled in followed by a new build on nuget? Radio silence for nearly a month is a bit scary...

@izikl
Copy link
Contributor

izikl commented Dec 23, 2016

@darvell Our team is on vacation for the holidays, but we plan to do it after the new year.

Happy new year 🎆

@dougnutz
Copy link

@darvell Sorry for the long delay we are planning to address this by the end of the week.

@dougnutz
Copy link

We have move this request in to a community branch https://github.com/bitstadium/HockeySDK-Windows/tree/community .
We will also be updating the docs appropriately. But in general new work will be going into the community branch, hi priority bug fixes and security issues will be addressed in the master branch. Our goal is to focus on Mobile center sdks (https://mobile.azure.com/) as the future of HockeySDK.

@andershol
Copy link

@dougnutz I can't see that benefit come from using two branches. It seems that this will only make i more cumbersome to work with.
Are you creating the nuget packages from the "community" branch? Otherwise it just seem like a backhanded way of rejecting the patch.
You focusing on the mobile center, shouldn't really affect which branch you accept patches into.
Anyway, I hope that you release a new nuget package with this badly needed functionality soon.

This is needed, as localized stack traces aren't recognized by the
server
...helpful if the app that uses HockeyApp wants to (deterministically)
execute own code after the HockeyApp crash handler (e.g. to show a
custom user interface)
@aelij
Copy link

aelij commented Jan 26, 2017

Hi, do you have an estimate when will this PR be merged and published to NuGet? This functionality is really missing.

The telemetry API doesn't work at all right now. I've spent quite a few hours trying to figure out why I'm not receiving any events.

@codekaizen
Copy link

What is the status of this PR? It looks like it has been approved for quite some time - why is it not merged in and released?

@glen-nicol
Copy link

Any way we can get this through? Session telemetry seems like core functionality that is sorely missed on WPF.

@darvell
Copy link

darvell commented Mar 3, 2018

I guess this PR has been abandoned like WPF. There's the community branch I guess but no way to get a nuget package from it. What a let down, WPF is still important since not everyone can build their products in a sandboxed environment, as well as a lot of us still have to target Vista/7 and this feature would be so handy.

Not trying to be too negative but HockeyApp has become an essential tool in desktop application dev and to have this sidelined is disheartening.

@elamalani
Copy link
Contributor

elamalani commented Mar 8, 2018

Hi everyone,

I'd like to share what our product team is working on and why are we a little hesitant to merge this PR. We don't want to abandon HockeyApp community at all, but our focus is shifted to work on this new product from Microsoft - App Center which is the next generation of HockeyApp. You can learn more about Visual Studio App Center on the HockeyApp website as well.

Given that we are heads down working on App Center since over a year and a half, we want all the new platforms and functionalities to be added in App Center, which has open source SDK just like HockeyApp. Adding new features in WPF platform is not a top priority for us at the moment. But it's in our backlog to support it in App Center as we know there is a large developer community targeting WPF apps. For HockeySDK, we instead created a community branch so that you all can contribute and work easily on that branch rather than waiting on us.

I hope you understand our rationale behind this. Please let me know if you have any questions and I'd be happy to answer them.

Thanks,
Ela

@dipree dipree closed this Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet