-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
@edoust thank you for your contribution, it looks good to me. One minor comment inline. |
@izikl thanks for the feedback. I tested the code on Windows 7 and Windows 8.1 (inside a virtual machine). All areas of the crash reports are filled with the correct information |
Any timeline on this being pulled in followed by a new build on nuget? Radio silence for nearly a month is a bit scary... |
@darvell Our team is on vacation for the holidays, but we plan to do it after the new year. Happy new year 🎆 |
@darvell Sorry for the long delay we are planning to address this by the end of the week. |
We have move this request in to a community branch https://github.com/bitstadium/HockeySDK-Windows/tree/community . |
@dougnutz I can't see that benefit come from using two branches. It seems that this will only make i more cumbersome to work with. |
This is needed, as localized stack traces aren't recognized by the server
...helpful if the app that uses HockeyApp wants to (deterministically) execute own code after the HockeyApp crash handler (e.g. to show a custom user interface)
Hi, do you have an estimate when will this PR be merged and published to NuGet? This functionality is really missing. The telemetry API doesn't work at all right now. I've spent quite a few hours trying to figure out why I'm not receiving any events. |
What is the status of this PR? It looks like it has been approved for quite some time - why is it not merged in and released? |
Any way we can get this through? Session telemetry seems like core functionality that is sorely missed on WPF. |
I guess this PR has been abandoned like WPF. There's the community branch I guess but no way to get a nuget package from it. What a let down, WPF is still important since not everyone can build their products in a sandboxed environment, as well as a lot of us still have to target Vista/7 and this feature would be so handy. Not trying to be too negative but HockeyApp has become an essential tool in desktop application dev and to have this sidelined is disheartening. |
Hi everyone, I'd like to share what our product team is working on and why are we a little hesitant to merge this PR. We don't want to abandon HockeyApp community at all, but our focus is shifted to work on this new product from Microsoft - App Center which is the next generation of HockeyApp. You can learn more about Visual Studio App Center on the HockeyApp website as well. Given that we are heads down working on App Center since over a year and a half, we want all the new platforms and functionalities to be added in App Center, which has open source SDK just like HockeyApp. Adding new features in WPF platform is not a top priority for us at the moment. But it's in our backlog to support it in App Center as we know there is a large developer community targeting WPF apps. For HockeySDK, we instead created a community branch so that you all can contribute and work easily on that branch rather than waiting on us. I hope you understand our rationale behind this. Please let me know if you have any questions and I'd be happy to answer them. Thanks, |
This pull request contains a stable implementation of the HockeySDK features for WPF:
The other telemetry works too (e.g. page views, exceptions, etc.) but I did not thoroughly test that
Attachments
Sample CrashReport