Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Commit

Permalink
Merge branch 'release/2.0.1'
Browse files Browse the repository at this point in the history
* release/2.0.1:
  Fix a warning
  Add device identifier of iPhone 4S
  Fix using wrong constant string
  Fix the reported iOS version to be the one of the crash report, instead the one when sending the report
  Use dispatch_once for initializing shared instance if deployment version >= 4.0
  Update demo project Xcode settings to use llvm
  • Loading branch information
DerAndereAndi committed Oct 18, 2011
2 parents 4f60097 + 1e9d8bc commit 44a0225
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 7 deletions.
23 changes: 20 additions & 3 deletions client/iOS/BWQuincyManager.m
Expand Up @@ -90,6 +90,22 @@ @implementation BWQuincyManager

@synthesize appIdentifier = _appIdentifier;

#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 40000
+(BWQuincyManager *)sharedQuincyManager
{
static BWQuincyManager *sharedInstance = nil;
static dispatch_once_t pred;

if (sharedInstance) return sharedInstance;

dispatch_once(&pred, ^{
sharedInstance = [BWQuincyManager alloc];
sharedInstance = [sharedInstance init];
});

return sharedInstance;
}
#else
+ (BWQuincyManager *)sharedQuincyManager {
static BWQuincyManager *quincyManager = nil;

Expand All @@ -99,6 +115,7 @@ + (BWQuincyManager *)sharedQuincyManager {

return quincyManager;
}
#endif

- (id) init {
if ((self = [super init])) {
Expand Down Expand Up @@ -288,7 +305,7 @@ - (BOOL)hasPendingCrashReport {


- (void) showCrashStatusMessage {
UIAlertView *alertView;
UIAlertView *alertView = nil;

if (_serverResult >= CrashReportStatusAssigned &&
_crashIdenticalCurrentVersion) {
Expand Down Expand Up @@ -321,7 +338,7 @@ - (void) showCrashStatusMessage {
break;
}

if (alertView != nil) {
if (alertView) {
[alertView setTag: QuincyKitAlertTypeFeedback];
[alertView show];
[alertView release];
Expand Down Expand Up @@ -483,7 +500,7 @@ - (void)_performSendingCrashReports {
[crashes appendFormat:@"<crash><applicationname>%s</applicationname><bundleidentifier>%@</bundleidentifier><systemversion>%@</systemversion><platform>%@</platform><senderversion>%@</senderversion><version>%@</version><userid>%@</userid><contact>%@</contact><description><![CDATA[%@]]></description><log><![CDATA[%@]]></log></crash>",
[[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleExecutable"] UTF8String],
report.applicationInfo.applicationIdentifier,
[[UIDevice currentDevice] systemVersion],
report.systemInfo.operatingSystemVersion,
[self _getDevicePlatform],
[[NSBundle mainBundle] objectForInfoDictionaryKey:@"CFBundleVersion"],
report.applicationInfo.applicationVersion,
Expand Down
11 changes: 7 additions & 4 deletions demo/iOS/QuincyDemo.xcodeproj/project.pbxproj
Expand Up @@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
objectVersion = 45;
objectVersion = 46;
objects = {

/* Begin PBXBuildFile section */
Expand Down Expand Up @@ -171,8 +171,11 @@
/* Begin PBXProject section */
29B97313FDCFA39411CA2CEA /* Project object */ = {
isa = PBXProject;
attributes = {
LastUpgradeCheck = 0410;
};
buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "QuincyDemo" */;
compatibilityVersion = "Xcode 3.1";
compatibilityVersion = "Xcode 3.2";
developmentRegion = English;
hasScannedForEncodings = 1;
knownRegions = (
Expand Down Expand Up @@ -238,6 +241,7 @@
GCC_OPTIMIZATION_LEVEL = 0;
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = QuincyDemo_Prefix.pch;
GCC_VERSION = com.apple.compilers.llvmgcc42;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
INFOPLIST_FILE = Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 4.3;
Expand All @@ -258,6 +262,7 @@
);
GCC_PRECOMPILE_PREFIX_HEADER = YES;
GCC_PREFIX_HEADER = QuincyDemo_Prefix.pch;
GCC_VERSION = com.apple.compilers.llvmgcc42;
GCC_WARN_ABOUT_MISSING_PROTOTYPES = YES;
INFOPLIST_FILE = Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 4.3;
Expand All @@ -276,7 +281,6 @@
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 3.0;
OTHER_LDFLAGS = "-all_load";
PREBINDING = NO;
RUN_CLANG_STATIC_ANALYZER = YES;
SDKROOT = iphoneos;
};
Expand All @@ -291,7 +295,6 @@
GCC_WARN_ABOUT_RETURN_TYPE = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 3.0;
PREBINDING = NO;
RUN_CLANG_STATIC_ANALYZER = YES;
SDKROOT = iphoneos;
};
Expand Down
3 changes: 3 additions & 0 deletions server/admin/common.inc
Expand Up @@ -223,6 +223,9 @@ function mapPlatform($device)
break;
case "iPhone3,3":
$platform = "4 CDMA";
break;
case "iPhone4,1":
$platform = "4S";
break;
case "iPad1,1":
$platform = "iPad";
Expand Down

0 comments on commit 44a0225

Please sign in to comment.