Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEP-21: document the protocol that's actually implemented by everyone #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jech
Copy link
Contributor

@jech jech commented Jul 19, 2018

@arvidn, @ghazel, please review.

@jech jech changed the title BEP-21: document the protocol that everyone actually implements. BEP-21: document the protocol that's actually implemented by everyone Sep 16, 2018
@jech
Copy link
Contributor Author

jech commented Sep 16, 2018

@arvidn, @ssiloti? I think it's embarrassing that the BEP describes a protocol different from what people actually implement.

is a peer that is incomplete without downloading anything more. This
happens for multi file torrents where users only download some of
the files.
This document describes an extension which allows a node to announce that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think of the term "node" to refer to a participant in the DHT, and "peer" as a participant in a bittorrent swarm. I believe this terminology is common among other BEPs as well. In your update you seem to use both "node" and "peer" interchangeably (unless I'm missing some subtlety).

Would it make sense to just use "peer"?

Sender operation
----------------

Upon connecting to a new peer, if the sending node is a partial peer, it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you would end up with 3 "peer" in this sentence. However, perhaps all uses of "partial peer" should be replaced by "partial seed" (as that's the term that established at the beginning)

@@ -59,7 +121,8 @@ the clients are announcing that they are partial seeds.
References
==========

.. _`BEP 0010`: http://www.bittorrent.org/beps/bep_0010.html
.. [#BEP-10] `BEP 0010`: Extension Protocol.
http://www.bittorrent.org/beps/bep_0010.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line-break seems gratuitous

@arvidn
Copy link
Contributor

arvidn commented Sep 16, 2018

looks good overall. The previous version did not attempt to describe how clients would use this (at was expected to be inferred). Your update goes so far to say a flag should be maintained for each peer to indicate whether it's a partial seed or not. It still doesn't say what that flag could be used for.

The only thing I can think of is to disconnect peers that are partial seeds and we're not interested in any of the pieces they have. That might be worth mentioning.

@jech
Copy link
Contributor Author

jech commented Sep 16, 2018 via email

@jech
Copy link
Contributor Author

jech commented Nov 13, 2018

Thanks, Arvid. Better now?

@jech
Copy link
Contributor Author

jech commented Apr 14, 2019

@arvidn ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants