Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Very noisy logging using gossip strategy #16

Closed
doughsay opened this issue May 4, 2017 · 5 comments
Closed

Very noisy logging using gossip strategy #16

doughsay opened this issue May 4, 2017 · 5 comments
Labels
strategies:gossip

Comments

@doughsay
Copy link
Contributor

doughsay commented May 4, 2017

Is this expected?

screen shot 2017-05-04 at 1 11 24 pm

It logs output at least once a second, sometimes more. This seems a bit overly chatty to me, and would blow up our centralized logging service...
@bitwalker
Copy link
Owner

It's definitely not expected, it should only be logging that if a connection is lost then re-established, this looks like it's just logging every time. I'll push a fix.

bitwalker added a commit that referenced this issue May 4, 2017
@bitwalker
Require topologies to provide a way to list nodes
e754f90 
- Provide a default implementation using `:erlang.nodes([:connected])`
- Deprecated `connect_nodes/3` and `disconnect_nodes/3`
- Add `connect_nodes/4` and `disconnect_nodes/4`
- Use new `list_nodes` option to do differencing and only log
  connects/disconnects when it's a new event as some strategies can be
  rather noisy without this (e.g. the gossip implementation)

See #16
@bitwalker
Copy link
Owner

I just pushed a new minor release, 2.1.0 which addresses this by requiring strategies to implement a list_nodes function. The default strategies will all cover this for you, so you should just be able to upgrade and be good to go!

@doughsay
Copy link
Contributor Author

doughsay commented May 5, 2017 via email

@doughsay
Copy link
Contributor Author

doughsay commented May 5, 2017

Sorry to bug; will you be pushing it to hex soon? :)

@bitwalker
Copy link
Owner

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
strategies:gossip
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doughsay @bitwalker