allow floats as weights #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
reviewed
Aug 25, 2018
| @@ -48,7 +48,7 @@ defmodule Graph.Edge do | |||
| label = Keyword.get(opts, :label) | |||
| weight = Keyword.get(opts, :weight, 1) | |||
| case {label, weight} do | |||
| {_, w} = meta when is_integer(w) -> | |||
| {_, w} = meta when is_integer(w) or is_float(w) -> | |||
There was a problem hiding this comment.
Can you replace all is_integer(w) or is_float(w) in this PR with is_number(w)?
|
Sorry for the delay, just one change required and I'll get this merged! |
Closed
|
Actually, it's fine, I can get it taken care of :) |
|
@bitwalker thanks! |
robindaumann
pushed a commit
to robindaumann/libgraph
that referenced
this pull request
Mar 26, 2019
allow floats as weights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if float weights were deliberately prohibited, trivial test case passes though.