Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tzdata to latest patch release #542

Closed
samhstn opened this issue Jul 2, 2019 · 1 comment
Closed

Update tzdata to latest patch release #542

samhstn opened this issue Jul 2, 2019 · 1 comment

Comments

@samhstn
Copy link

samhstn commented Jul 2, 2019

The Tzdata.ReleaseUpdater process will poll_for_update/0 every 5 hours.

The current 1.0.0 tzdata version sometimes produces the following error when Tzdata.ReleaseUpdater.poll_for_update() is run:

iex(1)> Tzdata.ReleaseUpdater.poll_for_update
[debug] Tzdata polling for update.
[info] tzdata release in place is from a file last modified Tue, 26 Mar 2019 05:40:14 GMT. Release file on server was last modified Mon, 01 Jul 2019 16:50:25 GMT.
[debug] Tzdata downloading new data from https://data.iana.org/time-zones/tzdata-latest.tar.gz
[debug] Tzdata data downloaded. Release version 2019b.
** (FunctionClauseError) no function clause matching in Tzdata.Util.first_matching_weekday_in_month/4

    The following arguments were given to Tzdata.Util.first_matching_weekday_in_month/4:

        # 1
        1932

        # 2
        4

        # 3
        7

        # 4
        []

    Attempted function clauses (showing 1 out of 1):

        defp first_matching_weekday_in_month(year, month, weekday, [head | tail])

    (tzdata) lib/tzdata/util.ex:73: Tzdata.Util.first_matching_weekday_in_month/4
    (tzdata) lib/tzdata/util.ex:329: Tzdata.Util.time_for_rule/2
    (tzdata) lib/tzdata/period_builder.ex:161: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:185: Tzdata.PeriodBuilder.calc_periods_for_year/9
    (tzdata) lib/tzdata/period_builder.ex:180: Tzdata.PeriodBuilder.calc_periods_for_year/9

This error has been addressed in lau/tzdata#83 and is in v1.0.1

We should update our tzdata dependency

from: {:tzdata, "~> 0.1.8 or ~> 0.5 or ~> 1.0.0"},

to: {:tzdata, "~> 0.1.8 or ~> 0.5 or ~> 1.0.1"}

@bitwalker
Copy link
Owner

It is already updated in master, but it is easily addressed in your own project by running mix deps.update tzdata

bryanhuntesl pushed a commit to binarytemple/is_it_up that referenced this issue Jul 8, 2019
binarytemple pushed a commit to binarytemple/is_it_up that referenced this issue Jul 8, 2019
* [grafana] Improve dashboard

* [make] attach-app-0

* [elixir] better counter

* [experiment] try montonic check strategy

* [experiment] check strategy

* [experiment] check strategy/metrics

* refactor/rename

* update tzdata - fix FunctionClauseError

bitwalker/timex#542

* [fix] DNS SRV - update namespace

* smarter handing of changed namespace

* [fix] Confex resolve :libcluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants