Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ASN.1 utcTime parsing/formatting support #136

Merged
merged 1 commit into from
Mar 19, 2016

Conversation

idyll
Copy link
Contributor

@idyll idyll commented Mar 18, 2016

Summary of changes

ASN1 (for crypto) has a specific (kinda ugly) time format - ASN.1 UTCTime.
This PR adds support to parse and format it.

Primarily this is needed to get a DateTime out of a certificate and then use Timex to check how long until that certificate expires. But it's useful for anything that used ASN.1. (Certificates, S/MIME, signed messages.)

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 70.657% when pulling f7131b9 on aai:asn1-utctime into 76b3e11 on bitwalker:master.

bitwalker added a commit that referenced this pull request Mar 19, 2016
Added ASN.1 utcTime parsing/formatting support
@bitwalker bitwalker merged commit ff4757b into bitwalker:master Mar 19, 2016
@bitwalker
Copy link
Owner

Looks great! Thanks for the PR, it's much appreciated! I'm holding off on a release until the localization stuff is polished up a bit better, but that won't be long. Hope that's ok!

@idyll
Copy link
Contributor Author

idyll commented Mar 19, 2016

Thanks! Totally fine. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants