Add microsecond support to Time.set/2 with :time option #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszpakowski
force-pushed
the
add-microsecond-support-to-time-set
branch
from
fa05b21
to
0299283
Compare
mszpakowski
force-pushed
the
add-microsecond-support-to-time-set
branch
from
0299283
to
bc06857
Compare
mszpakowski
changed the title
mszpakowski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR has been created to allow setting microseconds from Time struct. Current implementation has been counter-intuitive
where specifying
time: ~T[12:00:00.123456]option inTime.set/2didn't actually change the microseconds and additional optionmicrosecond: {123456, 6}was necessary to achieve that goal.I also noticed that setting date and time from structs didn't work for NaiveDateTime, so I have fixed that.
Checklist