remove datepicker style workaround #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpbw2
approved these changes
Feb 11, 2022
fedemkr
added a commit
that referenced
this pull request
Feb 11, 2022
* master: (34 commits) check email for null before authenticating (#1769) remove datepicker style workaround (#1768) Bump version to 2.16.2 (#1765) Improved code for periodic Autofocus on scan for better cancellation and task handlilng (#1764) Updated Sed expression for Android manifests (#1763) Bumped version to 2.16.1 (#1762) Add iOS Share Extension to our version bump automation (#1761) Bumped version to 2.16.0 (#1760) Improved Autofocus code on ScanPage for better cancellation and exception handling #1228 (#1759) [Help] Update links to new pattern (#1758) Client & Version headers (#1757) Autosync the updated translations (#1752) Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server (#1751) [Icons] Fast follower changes (#1750) Removed punctuation on some string resources regarding send (#1747) Set background of biometricCell from theme (#1744) Cleared About information about push registration, just left it in DEBUG mode (#1742) Cleared Console.WriteLine for iOS push notifications issue (#1739) Autosync the updated translations (#1734) Update FA icons on LockPasswordViewController (#1729) ...
fedemkr
added a commit
that referenced
this pull request
Feb 14, 2022
* master: [Icons] - BUG - Update groupings icon for collections (#1773) Autosync the updated translations (#1766) check email for null before authenticating (#1769) remove datepicker style workaround (#1768) Bump version to 2.16.2 (#1765) Improved code for periodic Autofocus on scan for better cancellation and task handlilng (#1764) Updated Sed expression for Android manifests (#1763) Bumped version to 2.16.1 (#1762) Add iOS Share Extension to our version bump automation (#1761) Bumped version to 2.16.0 (#1760) Improved Autofocus code on ScanPage for better cancellation and exception handling #1228 (#1759) [Help] Update links to new pattern (#1758) Client & Version headers (#1757) Autosync the updated translations (#1752) Fix delete account SSO with CME that the OTP parameter was being sent incorrectly to the server (#1751) [Icons] Fast follower changes (#1750) Removed punctuation on some string resources regarding send (#1747) # Conflicts: # src/Android/Properties/AndroidManifest.xml # src/iOS.Autofill/Info.plist # src/iOS.Extension/Info.plist # src/iOS.ShareExtension/Info.plist # src/iOS/Info.plist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We had a workaround for
DatePickerstyling that targeted iOS 13.2 and above. This workaround was actually supposed to be targeting 14.0 and above, so was throwing an error on anything between 13.2 and 14.0.Since we have upgraded to Xamarin 5.0.0.2125, we can remove this as Xamarin has fixed the issue
Code changes
Testing requirements
DatePickershould continue working correctly. There are examples on the Settings and EditSend screens.Before you submit