Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled Google Analytics Setting #27

Closed
kspearrin opened this issue Oct 14, 2016 · 11 comments
Closed

Disabled Google Analytics Setting #27

kspearrin opened this issue Oct 14, 2016 · 11 comments

Comments

@kspearrin
Copy link
Member

kspearrin commented Oct 14, 2016

We use google analytics to to better learn how the extension is being used by users so that improvements can be made. Some users to not want to be tracked in this way. Add an option in settings to allow a user to opt-out of of google analytics.

@kspearrin kspearrin changed the title Do Not Track Setting Disabled Google Analytics Setting Oct 14, 2016
@curtiszimmerman
Copy link

So what's the status on this issue? There is still no option to disable analytics. Why was it closed? It seems like you've just deflected the concerns of your users and then quietly closed the issue. Am I wrong?

@kspearrin
Copy link
Member Author

This option was added to the extension back in October with the 1.1.1 release. https://github.com/bitwarden/browser/releases/tag/v1.1.1

You can find the setting under Settings > Features

@hovancik
Copy link

Hi, what exactly is being tracked?

We use google analytics to to better learn how the extension is being used by users is kind of non-telling.

@kspearrin
Copy link
Member Author

Use use google analytics in a pretty traditional way: to track page views within the extension and certain events as they happen. For example, we collect how often the autofill feature is used through the current tab method vs the context menu method. This helps us determine which features are being used more often and how they are being used so that we can better make design decisions going forward.

@fancsali
Copy link

Sorry for being so blunt, but I believe, in order to really make me trust your app, you'd want to remove google analytics completely. At least that's my view, and based on issue #76, I am not alone...

@ghost
Copy link

ghost commented Jan 15, 2019

@kspearrin Just letting you know, we removed BitWarden from privacytools.io (https://github.com/privacytoolsIO/privacytools.io/issues/719). Opt-in telemetry is okay, but privacy-related applications shouldn't have something like Google Analytics enabled by default.

Please reconsider this.

@kspearrin
Copy link
Member Author

@Shifterovich Thanks for the heads up.

It turns out that the analytics weren't as insightful as I had hoped and didn't really end up getting used much. I've just removed them from all Bitwarden client applications for their next releases.

Ref:

@jeythekey
Copy link

Hi @kspearrin with ping to @Shifterovich,

being concerned about software tracking its users I was feeling really happy and kind of relieved reading your last post, because asides from the user tracking stuff I really love bitwarden.
I have, however, still some concerns about the use of Angulartics2/Angulartics2GoogleAnalytics code being injected all over the apps. Could you please elaborate shortly in which respect the angulartics approach (which seems to have been there from the first commit on) differs from using ga directly (which you removed)? Did the referenced commits, which apparently "shut up" the core ga-code also make all of the angulartics2-calls dysfunctional? Or what else justifies the statement, that google analytics was removed?

Simply put: Is there still any user data automatically being sent to google by the bitwarden apps?

That would be really appreciated.

Thanks for your understanding and the fantastic work!

@kspearrin
Copy link
Member Author

@jeythekey

Did the referenced commits, which apparently "shut up" the core ga-code also make all of the angulartics2-calls dysfunctional?

Yes.

All of the Angularlytics stuff are just helpers that end up calling into the ga() function that you see was disabled here: bitwarden/jslib@f4c4f28

Essentially Angularlytics has now been "black holed". There is nothing in the apps that is connected to or makes calls to Google Analytics. You could verify this by monitoring your network tab in the browser's dev tools.

@jeythekey
Copy link

Waoh, thank you so much for clarifying this so quickly!! I suspected that but was not sure, if it might work somehow in parallel. Really happy now :)

@fancsali
Copy link

fancsali commented Aug 9, 2019

This is great news, however bitwarden/jslib@f4c4f28 seems to only add a return statement.

I was just wondering, whether the code could be completely removed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants