Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8, 12, 24 hours timeout option and respective translations. #1851

Closed
wants to merge 3 commits into from
Closed

Conversation

rarepops
Copy link

@rarepops rarepops commented May 16, 2021

Might need some help with Bengali as well as Google Translate says that

"hour" = "ঘন্টার"
"1 hour" = "1 ঘন্টা"
"4 hours" = "4 ঘণ্টা"
"8 hours" = "8 ঘন্টা"

There are subtle differences I am not well versed in and don't know which is the correct way.

See: https://community.bitwarden.com/t/add-8-12-and-24-hours-timeout-options/29996

@CLAassistant
Copy link

CLAassistant commented May 16, 2021

CLA assistant check
All committers have signed the CLA.

@rarepops
Copy link
Author

Also, it seems when I am trying to build, it gets stuck, so I couldn't actually test it

[./src/popup/images/logo-dark@2x.png] 43 bytes {mini-css-extract-plugin} [built]
    [./src/popup/images/logo-white@2x.png] 44 bytes {mini-css-extract-plugin} [built]
        + 9 hidden modules

However, trying to add whatever was built will give me 2 warnings:

  "applications": {
    "gecko": {
      "id": "{446900e4-71c2-419f-a6a7-df9c091e268b}",
      "strict_min_version": "42.0"
    }
  },

and

"sidebar_action": {
    "default_title": "Bitwarden",
    "default_panel": "popup/index.html?uilocation=sidebar",
    "default_icon": "images/icon19.png"
  }

@eliykat
Copy link
Member

eliykat commented May 17, 2021

Hi @Rares95, thanks for the PR. Just a heads up that all our translations are managed by CrowdIn. This means that you only need to add the UI strings to en/messages.json (in English), and CrowdIn translators will handle everything else. It also means that we can't accept any changes to the other messages.json files via Github, as they'll be overwritten the next time CrowdIn translations are merged across.

As a starting point, can you please revert all your changes to all other messages.json files. I'll then schedule this for further review.

@rarepops
Copy link
Author

rarepops commented May 17, 2021

@eliykat Done! Please review ebf2d1e

@eliykat
Copy link
Member

eliykat commented May 24, 2021

Hey @Rares95, thanks for making those changes so quickly. I'll raise this internally to see if we can progress to code review. I'll keep you posted.

@cscharf cscharf self-assigned this May 24, 2021
@cscharf cscharf added discussion hold do not merge, do not approve yet labels May 24, 2021
@cscharf
Copy link
Contributor

cscharf commented May 24, 2021

Please see community forum thread for feedback and discussion points. Thanks @Rares95 !

@eliykat eliykat marked this pull request as draft May 27, 2021 04:26
@FranciscoKloganB
Copy link

Great work! Considered opening a PR for this as well. Glad to see someone beat me to it and even included the solution.

@Hinton Hinton closed this Sep 27, 2021
@Hinton Hinton reopened this Sep 27, 2021
@Hinton
Copy link
Member

Hinton commented Sep 27, 2021

I believe this pull request is no longer necessary since we've added a "Custom Vault Timeout" option which will be included in the next release, #2048 which should allow arbitrary timeouts.

@eliykat eliykat closed this Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion hold do not merge, do not approve yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants