New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 8, 12, 24 hours timeout option and respective translations. #1851
Conversation
Also, it seems when I am trying to build, it gets stuck, so I couldn't actually test it
However, trying to add whatever was built will give me 2 warnings:
and
|
Hi @Rares95, thanks for the PR. Just a heads up that all our translations are managed by CrowdIn. This means that you only need to add the UI strings to As a starting point, can you please revert all your changes to all other |
Hey @Rares95, thanks for making those changes so quickly. I'll raise this internally to see if we can progress to code review. I'll keep you posted. |
Please see community forum thread for feedback and discussion points. Thanks @Rares95 ! |
Great work! Considered opening a PR for this as well. Glad to see someone beat me to it and even included the solution. |
I believe this pull request is no longer necessary since we've added a "Custom Vault Timeout" option which will be included in the next release, #2048 which should allow arbitrary timeouts. |
Might need some help with Bengali as well as Google Translate says that
"hour" = "ঘন্টার"
"1 hour" = "1 ঘন্টা"
"4 hours" = "4 ঘণ্টা"
"8 hours" = "8 ঘন্টা"
There are subtle differences I am not well versed in and don't know which is the correct way.
See: https://community.bitwarden.com/t/add-8-12-and-24-hours-timeout-options/29996