Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 12/24 hour lock options #1170

Closed

Conversation

mcanning
Copy link

@mcanning mcanning commented Mar 7, 2020

Hi! I recently converted from lastpass and noticed the maximum lock duration was 4 hours. This results in needing to re-login over the course of a single work day (which can be a minor annoyance) but was noticeable when trying to make the move.

I've added 12 and 24 hours here and updated locales, if you think this is too much clutter for the UI I would be more than happy to just use one or the other.

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2020

CLA assistant check
All committers have signed the CLA.

@LaurentOngaro
Copy link

please, can you approve this PR, it's very very useful for me

@Clonkex
Copy link

Clonkex commented Jun 10, 2020

OP needs to sign the CLA before the PR can be approved.

@mcanning
Copy link
Author

OP needs to sign the CLA before the PR can be approved.

Done

@fbarbeira
Copy link

This is interesting, it would allow our users to unlock once per day their vault instead of two.

If I have to choose it would be better to add only an 8h option to accomplish the user goal of unlock one time per day.

@cscharf
Copy link
Contributor

cscharf commented Sep 17, 2020

@mcanning , please revert all changes to the localization files, except for src/_locales/en/messages.json, that file "seeds" our crowdin integration for translation everywhere else, otherwise the translation links will break or fail to get updated in future syncs.

Also, for consistency across clients, this type of change would also need to be made in all other client repos that offer the same timeout options, including: web, desktop, mobile. This would also need to be controllable by policy and therefore in the web vault under user timeout policy the expanded options would need to be added there, as well as in the new business portal under the same (policies).

Let me know if you have any questions or concerns. I would also encourage you to use the Bitwarden Community Forums which has a section for submitting, voting for, and discussing product community contributions like this one if you need more assistance in requirements, areas to focus and final approval of approach, content, etc. before getting too far into the weeds.

@eliykat
Copy link
Member

eliykat commented May 27, 2021

I'm closing this as inactive because change requests from September have not been actioned. There is a more current effort to revamp the timeout options here (which you're welcome to get involved in if you still want to help): #1851.

@eliykat eliykat closed this May 27, 2021
addisonbeck pushed a commit that referenced this pull request May 5, 2022
eliykat pushed a commit that referenced this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants