bw sync reports as successful even when server is unreachable

[fredrikekre]

bw sync reports as successful even when server is unreachable. In contrast, the Firefox browser plugin instead gives an error message Syncing failed as expected.

Might be the same root cause as #12 but this is for a very different reason so opening a new issue.

Here is a reproducible example (using bitwarden_rs as a server, but should be irrelevant).

$ docker run -d --name bitwarden -p 8000:80 bitwardenrs/server
57acead31b52fca12a5fd8b803c048c2c6e35c20d936afa00c57747446afc81c

$ bw config server http://localhost:8000
Saved setting `config`.

Create a dummy user from the browser and login

$ bw login
[...]

$ export BW_SESSION="..."

Syncing works as expected

$ bw sync
Syncing complete.

$ bw sync --last
2020-04-16T14:55:33.112Z

Now shut down the server

$ docker stop bitwarden 
bitwarden

and yet bw sync reports succesful syncing, but checking last sync time verifies that it wasn't actually syncing.

$ bw sync
Syncing complete.                     # <--- ???

$ bw sync --last
2020-04-16T14:55:33.112Z

Version:

$ bw --version
1.9.1

[fredrikekre]

Stumbled upon this again; still present with

$ bw --version
1.13.2