Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TLD's not recognized as in URLs #2811

Closed
Nokel81 opened this issue Mar 30, 2020 · 3 comments · Fixed by #3168
Closed

Some TLD's not recognized as in URLs #2811

Nokel81 opened this issue Mar 30, 2020 · 3 comments · Fixed by #3168
Labels

Comments

@Nokel81
Copy link

Nokel81 commented Mar 30, 2020

Bug Summary

The "launch URL" button when editing a login item is sometime greyed out (ie not active) for URLs using some TLDs (top level domains).

Steps to reproduce

  1. Type into the item's "URL 1" field the url: www.doormonster.tv.
  2. Observe that the first button to the right of the field, with hover text "launch URl" is still greyed out.

Expected Behaviour:

That the it is active since the text is a fully valid URL.


Notes:

A list of valid TLDs are provided by the Internet Assigned Numbers Authority in plain text.

@KazuAlex
Copy link

KazuAlex commented May 3, 2020

Hey,

There is the same problem with uppercase tld.
For example, "google.com" works, but "google.COM" (or COm, Com, cOM, etc.) doesn't work properly.
Also, "calendar.google.com/calendar" are not working, but uri is good.
Globally, this is a problème with the "launchUri()" function in jslib/src/models/view/loginUriView.ts and Utils.tldEndingRegex regex.
Also, we can define any hostname without tld or with any weird tld we want in our OS (like in /etc/hosts).
I suggest removing the tld ending check.
I think this is the behavior of many web browser : any tld is accepted : goog.le for example, but the browser says it cannot find that site.

This is the responsibility of the user to be careful about what they write in this case (like any other).
Controls need to be here to help user, not private it from functionalities.

@bitwarden-bot
Copy link

Hi @Nokel81,
We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it.
Thanks!

@Nokel81
Copy link
Author

Nokel81 commented Apr 12, 2022

Yup this is still an issue.

@dwbit dwbit removed the stale label Apr 12, 2022
@Hinton Hinton added the web label Jun 2, 2022
@Hinton Hinton transferred this issue from bitwarden/web Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants