Remove tld checking #100
Remove tld checking #100
Conversation
|
|
src/models/view/loginUriView.ts
Outdated
| @@ -95,6 +95,6 @@ export class LoginUriView implements View { | |||
| } | |||
|
|
|||
| get launchUri(): string { | |||
| return this.uri.indexOf('://') < 0 && Utils.tldEndingRegex.test(this.uri) ? ('http://' + this.uri) : this.uri; | |||
| return this.uri.indexOf('://') < 0 ? ('http://' + this.uri) : this.uri; | |||
There was a problem hiding this comment.
This change should also be done to the isWebsite code above.
|
However, I think that it probably would be a good idea to check the |
There are a RFC about the uri format. But i don't know exactly the acceptations. |
|
Fair I guess |
KazuAlex
force-pushed
the
bitwarden/web/fix-507
branch
from
8cfef26
to
7914701
Compare
KazuAlex
force-pushed
the
bitwarden/web/fix-507
branch
from
7914701
to
92455d1
Compare
|
We use GitHub issues as a place to track bugs and other development related issues. The Bitwarden Community Forums has a section for submitting, voting for, and discussing product feature requests like this one. Please sign up on our forums and search to see if this request already exists. If so, you can vote for it and contribute to any discussions about it. If not, you can re-create the request there so that it can be properly tracked. This issue will now be closed. Thanks! |
Fix bitwarden/clients#2811
Uri doesn't systematically have a tld. Even more from the list defined in the regex "tldEndingRegex" (/.*.(com|net|org|edu|uk|gov|ca|de|jp|fr|au|ru|ch|io|es|us|co|xyz|info|ly|mil)$/) in src/misc/utils.ts
Considere the uri as a "http" resource if the user doesn't provide a scheme.