Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance in v2023.7.0 for Edge extension #5807

Closed
1 task done
trparky opened this issue Jul 13, 2023 · 84 comments
Closed
1 task done

Slow performance in v2023.7.0 for Edge extension #5807

trparky opened this issue Jul 13, 2023 · 84 comments
Labels
browser Browser Extension bug

Comments

@trparky
Copy link

trparky commented Jul 13, 2023

Steps To Reproduce

It asks for the password again even though I told the extension to not ask for the password again until a browser restart and to use a PIN instead. But then there are times that it has a mind of its own and it doesn't show anything on the UI slab that comes down from the extension icon.

I can't even follow the rules of filing a bug since this is just so buggy.

Expected Result

I don't even know what to fill in here.

Actual Result

I don't even know what to fill in here.

Screenshots or Videos

No response

Additional Context

I've had to go and install the older v2023.5.1 from the Google Extension store to get a working version of the Bitwarden extension. How did this pass quality checks?

Operating System

Windows

Operating System Version

Windows 10

Web Browser

Microsoft Edge

Browser Version

114.0.1823.79

Build Version

2023.7.0

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@trparky trparky added browser Browser Extension bug labels Jul 13, 2023
@michael-r-elp
Copy link

michael-r-elp commented Jul 13, 2023

Have the same issue as well, opening up the extensions, I was greeted with a login prompt including it asking for 2FA, I had the checkboxes checked to not ask again, when I went to a site to fill a password out, it asked me again for credentials including 2FA.

Afterwards it worked somewhat fine, except that it takes quite long to open, where I then see a white background with a loading animation for 10-12 seconds, every time I open the extension.

Browser I used is MS Edge and the extension is also installed from the Edge Add-On Store.

@TheDuffman85
Copy link

Same here. The browser extension for Edge is unusable with the July update. Is there a way to block the update for our users until the issue is resolved? There doesn't seem to be a possibility within Edge to disable auto updates for extensions.

@MaciejPel
Copy link

I've got the same issue, extension asked to login with email and master password despite having different settings. After logging in it wouldn't auto fill password (with shortcut). Browser restart caused full log out and I had to login with email and master password again.
finally I switched from MS edge store 2023.7.0 version to Chrome 2023.5.1 and it's fine

@NothingCtrl
Copy link

I have the same issue after Windows 11 update, the extension is not load, and very high CPU every time I click on the extension icon.

  • OS version: Windows 11 Pro 22H2 build 22621.1992
  • MS Edge version: 114.0.1823.79 (Official build) (64-bit)
  • Bitwarden extension version: 2023.7.0

Tried reinstalling the extension but same issue.

image

@Lincest
Copy link

Lincest commented Jul 13, 2023

Installing the chrome version of the extension on the edge solves the problem for now, hopefully it will be fixed soon! 🙏

@isaacyew
Copy link

isaacyew commented Jul 13, 2023

Having the same issue as well.

  • OS version: Win 11 Ent 22H2 22631.1972
  • Edge: Version 114.0.1823.79 (Official build) (64-bit)
  • Bitwarden extension: 2023.7.0 (from MS Edge store)

Some error msg received in the extension:

ERROR Error: Uncaught (in promise): TypeError: Cannot read properties of null (reading 'map') TypeError: Cannot read properties of null (reading 'map')

Context

extension://jbkfoedolllekgbhcbcoahefnbanhhlh/popup/index.html#/lock

Stack Trace
popup/main.js:1 (e.initializeAs.e.initializeAs.i)
popup/main.js:1 (dA.<anonymous>)
popup/main.js:1 (anonymous function)
popup/polyfills.js:2 (new N)
popup/main.js:1 (uA)
popup/main.js:1 (dA.update)
popup/main.js:1 (dA.<anonymous>)
popup/main.js:1 (r)
1
2
Uncaught (in promise) Error: No tab with id: 1299638102.

Context

extension://jbkfoedolllekgbhcbcoahefnbanhhlh/background.js

Stack Trace

background.js:2 (anonymous function)
1
2
Uncaught Error: Could not establish connection. Receiving end does not exist.

Context

extension://jbkfoedolllekgbhcbcoahefnbanhhlh/background.js

Stack Trace

background.js:2 (anonymous function)

@idimopoulos
Copy link

It seems to be on Edge (maybe more browsers but these here seem to revolve around edge). Indeed, #5807 (comment) helps. Just go to the chrome extension page and install it. Edge accepts it and you will have the extension two times.

@Fridgeir-9
Copy link

here the same with Edge add-on

@djsmith85 djsmith85 changed the title New version is completely broken Slow performance in v2023.7.0 for Edge extension Jul 13, 2023
@djsmith85
Copy link
Contributor

Closed #5808 as duplicate and changed title here as more descriptive.

@WasserEsser
Copy link

WasserEsser commented Jul 13, 2023

In addition to "slow performance", the context menu won't show any logins and the extension refuses to auto-fill on most websites now. It's completely unusable.

@Padanian
Copy link

Same here

@vherrlein
Copy link

vherrlein commented Jul 13, 2023

Chrome Version 2023.5.1 installed into Edge works fine:

image

@jose-duarte
Copy link

I guess the reason why it works fine with the chrome store version is because it's still version 2023.5.1

@chinagaofeng
Copy link

save here, and the CPU usage riseup

@hapklaar
Copy link

Same here on Windows 11 with Edge. Edge on MacOS doesn't seem to be affected, although also seems a bit slower.

@Possemaster
Copy link

Temporary Solution: Remove Edge version and install the Chrome store variant in Edge (https://chrome.google.com/webstore/detail/bitwarden-free-password-m/nngceckbapebfimnlniiiahkandclblb?hl=nl)
This is still an older version without this issue.

@kt-1
Copy link

kt-1 commented Jul 13, 2023

Experiencing the same issue here. Microsoft Edge extension is unusable in current state. Clicking on the extension icon in the browser tool bar results in 32 second delay: 25 seconds of white background with spinning circles animation, then about another 7 seconds until matching vault accounts are displayed. This happens every time you click on the icon. Auto-fill is also broken. Windows 11 22H2 build 22621.1992, Microsoft Edge 114.0.1823.79, 8 Core Xeon processor with 64GB RAM. Tried removing the extension and re-installing; experience remained the same.

@Caseum96
Copy link

We are experiencing the same issue. And some users experiencing another problem: They cant login directly to Bitwarden. They will get an "unable to fetch" error. But I'm not sure the second issue is related to the first one.

@quexten
Copy link
Contributor

quexten commented Jul 13, 2023

I built 22cb3d5 (2023.7.0) from source. I'm able to reproduce in Firefox. I did have to do a full reset of application data, and a login afterwards to trigger. Though.. it did seem to be somewhat less laggy than on Edge.

@JoaoMXN
Copy link

JoaoMXN commented Jul 13, 2023

Same here. On task manager (Windows 11), it says that the process/file "chrome-extension://jbkfoedolllekgbhcbcoahefnbanhhlh/background.js" is the culprit consuming the CPU and RAM that OP reported.

@xyxzxyz
Copy link

xyxzxyz commented Jul 13, 2023

Temporary Solution: Remove Edge version and install the Chrome store variant in Edge (https://chrome.google.com/webstore/detail/bitwarden-free-password-m/nngceckbapebfimnlniiiahkandclblb?hl=nl) This is still an older version without this issue.

Chrome version is still slow but not unusable like Edge version.

@quexten
Copy link
Contributor

quexten commented Jul 13, 2023

image

This is the profiling result of when the cpu usage goes to 110% shortly after locking for multiple seconds (and ram increases to 2GB).

Edit: Actually the behaviour on firefox, while troubling, seems different from edge. It might be completely unrelated, so don't pay too much attention to the profiling result above.

@Xerionty
Copy link

Xerionty commented Jul 13, 2023

Same issue here.

Chrome store version (2023.5.1) is still working (I just verified)
https://chrome.google.com/webstore/detail/bitwarden-free-password-m/nngceckbapebfimnlniiiahkandclblb?hl=nl

@Korvenwin
Copy link

+1

@themarv1
Copy link

Same Issue here und Edge for Windows 11. Itrs loading 10-30 Seconds and them sometimes an Entry comes up. But he cant Autofill the Loginforms.
Screenshot 2023-07-13 103831

@michael-r-elp
Copy link

Just tested the 2023.7.1 version in Edge, the bug seems fixed there, no idea what they changed though

@michael-r-elp
Copy link

michael-r-elp commented Jul 13, 2023

Comparing to master browser-v2023.7.0...master it seems there were changes made to files within apps/browser so the tag may just have been made before the changes were added.

EDIT: Actually nvm, none of them really seem like real code changes, so idk what the change was.
EDIT2: Ok, I just overlooked some changes, there actually seem to be changes, that probably fixed the bug.

@mcswainy
Copy link

So, any idea on the release schedule through Extension stores?

@michael-r-elp
Copy link

michael-r-elp commented Jul 13, 2023

According to https://learn.microsoft.com/en-us/microsoft-edge/extensions-chromium/publish/update-extension the Verification Process can take up to 7 business days.

When taking into account the time between the 7.0 release and the time the issue here was opened, we could probably assume about 6 hours, hopefully less if everything goes well.

@trparky
Copy link
Author

trparky commented Jul 13, 2023

What I'd really like to know is how the heck did this absolutely obvious bug pass quality control checks at Bitwarden. I mean usually they're usually good about catching the show stopping bugs like this one but wow, this passed right over their heads with light years to spare.

@michael-r-elp
Copy link

Does make me wonder as well, at least it seems they noticed before releasing it to other browsers.

@trparky
Copy link
Author

trparky commented Jul 13, 2023

What? Is Chrome the red-headed stepchild here?

@mcswainy
Copy link

What I'd really like to know is how the heck did this absolutely obvious bug pass quality control checks at Bitwarden. I mean usually they're usually good about catching the show stopping bugs like this one but wow, this passed right over their heads with light years to spare.

That... Is the question right?

@afhpayne
Copy link

Serious UI slowdown, fails to auto-enter User/PW in Edge, CPU spikes and excessive fan use.

@hapklaar
Copy link

Can confirm 2023.7.1 fixes the issue. For anyone wanting to test, you can download the zip here, unpack and 'load unpacked' from the Edge extension screen.

@Padanian
Copy link

Padanian commented Jul 13, 2023

2023.7.1 works for me.

@trparky
Copy link
Author

trparky commented Jul 13, 2023

Now, if Bitwarden can get this fixed version out and convince Google and Microsoft to push it out with much haste to their respective extension stores.

@mcswainy
Copy link

Just forced an update on MS Edge extensions and got the new version installed. The previous issue was resolved and functioning normally.

@Bovive
Copy link

Bovive commented Jul 13, 2023

Just forced an update on MS Edge extensions and got the new version installed. The previous issue was resolved and functioning normally.

Worked for me too, thanks!

@michael-r-elp
Copy link

Just forced an update on MS Edge extensions and got the new version installed. The previous issue was resolved and functioning normally.

Can confirm, seems the Update is on the Edge Addon Store and can be force updated in Edge by

  1. going to edge://extensions/
  2. enabling Developer Mode if it's not on already and
  3. pressing the refresh button that should pop-up after enabling developer mode.
  4. Afterwards developer mode can be safely turned off again, if desired.

@cverburgh
Copy link

The above worked for me, thanks!

@danmullen
Copy link

Thanks @michael-r-elp, that's fixed it for me.

@agentdr8
Copy link

agentdr8 commented Jul 13, 2023

2023.7.1 performance is much better in Edge, but appears to have broken the Unlock with biometrics integration with the desktop app (or maybe this is always the case with extensions installed manually and not via the store?).

@vherrlein
Copy link

vherrlein commented Jul 13, 2023

The new version 2023.7.1 published on th Microsoft Store works well.

Just because an missing await in JS did that ?#5801

Just for my knowledge, how could we mitigate that kind of behavior?

@trparky
Copy link
Author

trparky commented Jul 13, 2023

Just for my knowledge, how could we mitigate that kind of behavior?

Oh, I don't know... proper testing and quality control which Bitwarden failed at big time this time around.

@vherrlein
Copy link

vherrlein commented Jul 13, 2023

Just for my knowledge, how could we mitigate that kind of behavior?

Oh, I don't know... proper testing and quality control which Bitwarden failed at big time this time around.

No one is perfect we’re all humans 😊
Each mistake is an opportunity to improve ourselves.

I didn’t review the the full source code, may be it’s not easy to put in place an automated unit test!

Before a major release, would it be more reliable to publish a beta version ?

Let’s notice another important point, Bitwarden team was really fast for releasing the hot fix version.
Thank you very much.

@trparky
Copy link
Author

trparky commented Jul 13, 2023

Before a major release, would it be more reliable to publish a beta version ?

I'd think so.

No one is perfect we’re all humans 😊
Each mistake is an opportunity to improve ourselves.

True, but it seems that the omission of one keyword, namely await, seems a little... dumb.

@djsmith85
Copy link
Contributor

Closing this now, as 2023.7.1 has been released and the community has reported it's resolved the issue.

For anyone curious about the cause:

  • A manifest file, with the wrong manifest version, was uploaded to the MS Edge store, and only there. All other browser stores have the correct version and are being rolled out as planned. Bitwarden has taken steps to avoid this from happening in the future.

@lucianmoldovanu
Copy link

lucianmoldovanu commented Jul 14, 2023

At this very moment, on latest Edge (Version 114.0.1823.82 (Official build) (64-bit)) I cannot download the extension from the Edge store, after having uninstalled it (in order to force an update this way).

image

This is a sample link which is attempted to be downloaded from via the store directly.

@ovidiupruteanu
Copy link

I'm having the same issue when trying to download 2023.7.1. Also tested on a fresh Edge browser.

@LanceMcCarthy
Copy link

LanceMcCarthy commented Jul 14, 2023

I was able to install it, same Edge release, from this store location => https://microsoftedge.microsoft.com/addons/detail/bitwarden-free-password/jbkfoedolllekgbhcbcoahefnbanhhlh

Maybe there's an issue with the search result's button, try the landing page and use its install button (do a cache refresh too, shift + ctrl + r)

@ovidiupruteanu
Copy link

I cleared the cache and tried the landing page, same error.

@ovidiupruteanu
Copy link

For anyone still having this issue, it looks like it's a problem with the Microsoft store's CDN. I used a US VPN and was able to download it.

@lucianmoldovanu
Copy link

From my side this issue seems to be solved now, without any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests