Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox pin not saved #7404

Closed
1 task done
mrlinuxfish opened this issue Dec 31, 2023 · 18 comments
Closed
1 task done

Firefox pin not saved #7404

mrlinuxfish opened this issue Dec 31, 2023 · 18 comments
Labels
browser Browser Extension bug

Comments

@mrlinuxfish
Copy link

Steps To Reproduce

  1. Check "use pin to unlock" and set pin
  2. Navigate away from settings tab
  3. Navigate back to settings tab
  4. Pin is no longer set and setting is unchecked

Expected Result

Setting a pin should be saved until the extension is logged out (as specified by the tooltips in the settings)

Actual Result

Navigating away from the settings tab unsets the use pin to unlock setting. Pin is not remembered and extension requests the master password

Screenshots or Videos

bitwarden.2023.12.1.pin.bug.firefox.mp4

Additional Context

No response

Operating System

Windows

Operating System Version

11 23h2

Web Browser

Firefox

Browser Version

121.0

Build Version

2023.12.1

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@mrlinuxfish mrlinuxfish added browser Browser Extension bug labels Dec 31, 2023
@SergeantConfused
Copy link

Hi @mrlinuxfish,

Thank you for this report. Could you please uninstall the Bitwarden browser extension from Firefox, remove any leftover data, then install it anew and let me know if this behaviour continues?

Thank you in advance,

@mrlinuxfish
Copy link
Author

I'm reasonably confident I cleared the extension data. You need to have the extension installed to view the UUID, so it's possible I only cleared out data for one instance of it being installed.

Still has the same issue after reinstalling

@SergeantConfused
Copy link

Hi @mrlinuxfish,

Thank you.

  1. Could you please detail how your browser is set up? Screenshots of the Settings menus would be very helpful.
  2. What other extensions are installed on Firefox?
  3. Do you encounter the same behaviour in a new Firefox Profile?

I'd like to gather more information as I am unable to reproduce this myself; If you would like to share that information directly with us instead of publicly on GitHub, please feel free to create a support ticket and please include a link to this GitHub report in it and we'll proceed.

Thank you in advance,

@lugoazul
Copy link

lugoazul commented Jan 2, 2024

Hello. I have the same problem and I had already opened a ticket for your support more than month ago. I tried all the suggested described here, as well as testing with a new profile. Nothing worked.

@cbrand-ludlums
Copy link

I think I've come across a solution for this. In Firefox, the Bitwarden browser extension may need the "Read and modify privacy settings".

I had this same issue and I've uninstalled/reinstalled the extension and still had the same issue. I checked the extension permissions and thought I'd enable the permission for "Read and modify privacy settings"
image
After I enabled this permission, the Unlock with Pin setting stayed.
Could also be a coincidence too that it stayed.

@lugoazul
Copy link

lugoazul commented Jan 3, 2024

I think I've come across a solution for this. In Firefox, the Bitwarden browser extension may need the "Read and modify privacy settings".

I had this same issue and I've uninstalled/reinstalled the extension and still had the same issue. I checked the extension permissions and thought I'd enable the permission for "Read and modify privacy settings"
After I enabled this permission, the Unlock with Pin setting stayed. Could also be a coincidence too that it stayed.

Well, thank you! That worked for me as well. I just hope it holds until this issue is fixed as I am really tired of entering the password.

@mrlinuxfish
Copy link
Author

I tried the settings change and a new profile, but it's still not saving.

@lugoazul
Copy link

lugoazul commented Jan 3, 2024

I tried the settings change and a new profile, but it's still not saving.

Well, that was short. Neither for me... One day after and it no longer works....

@gfairchild
Copy link

I'm experiencing this same issue. FF 121.0, BW extension 2023.12.1.

@Brefar
Copy link

Brefar commented Jan 5, 2024

I tried to set the pin from sidebar and it retained it. None of the other methods worked for me. So give that a try. I couldn't figure out how to open the sidebar for it again, but when I disabled and re-enabled it, the sidebar opened and I added the pin there. Good luck!

@gfairchild
Copy link

I tried to set the pin from sidebar and it retained it. None of the other methods worked for me. So give that a try. I couldn't figure out how to open the sidebar for it again, but when I disabled and re-enabled it, the sidebar opened and I added the pin there. Good luck!

I just tried this, and it unfortunately didn't work for me.

@gfairchild
Copy link

I just got it to work. I first checked the "Unlock with PIN" box and set the PIN. Then, I hit "Lock Now", which is just below the "Unlock with PIN" checkbox. This immediately showed me the PIN unlock prompt, and it seems to be working now. I suspect that the setting isn't being properly saved automatically, but forcing BW to lock does properly save the setting.

@Yoldark34
Copy link

Hello,
I failed too many times the pin code, i got log out, i used the master password and the 2FA to log in, i tried re enabling the pin code without success.
I can only enable the pin code if i uncheck "Lock with the master password after browser restart" (from the pin code popup).

I tried the solutions from the thread without success, i tried removing and installing back the extension and i tried rebooting FF 121.0.

Thanks :P

@mrlinuxfish
Copy link
Author

Update, I found I can set the pin if I uncheck "Lock with master password on browser reset".

I won't use it this way as it seems to be less secure though

@SergeantConfused
Copy link

Hello everyone,

Thank you for your patience and input. I am now able to reproduce this behaviour with Bitwarden 2023.12.1 on Firefox 121.0, and I've routed this internally.

Reproduction steps:

  1. Open the Bitwarden browser extension in Firefox, and navigate to the (Settings) menu and click on (Unlock with PIN).
  2. Enter a 4 digit PIN code and keep the (Lock with master password on browser restart) option activated and click on (Ok).
  3. Navigate to the (Generator) menu and then navigate back to the (Settings) menu.
    At this point you will see that the (Unlock with PIN) function is deactivated.

Notes:

  1. @gfairchild's workaround here works. Thank you for sharing that.
  2. The (Unlock with PIN) function also works as expected if you deactivate the (Lock with master password on browser restart) option when setting the PIN, as @mrlinuxfish mentioned.

If anyone wishes to add further information, such as screenshots or screen recordings, please feel free to do so at any time - our Engineering team will be happy to review them.

Thank you all again,

@sleepyh34d
Copy link

Running Windows 11 23H2, Firefox 121.0.1, and Bitwarden 2023.12.1. @gfairchild's workaround solved the issue for me.

After applying the workaround, I noticed that when disabling 'Unlock with PIN', navigating away from Bitwarden, then going back and re-enabling it, the setting worked as expected. However, if I disabled 'Unlock with PIN' and selected 'Lock Now', then unlocked it and attempted to re-enable 'Unlock with PIN', the setting wouldn't save until applying the workaround once again. Hope this helps!

@mrlinuxfish
Copy link
Author

This issue appears to be fixed on 2024.1.0

@lugoazul
Copy link

Indeed it seems, although there's no mention about it in release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Browser Extension bug
Projects
None yet
Development

No branches or pull requests

8 participants