-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox Status #8
Comments
Oct 8th status Queue Position: 57 of 165 |
Oct 11th status Queue Position: 38 of 145 |
Oct 13th status Queue Position: 20 of 137 |
@kspearrin The link in the readme and issue description is now 'not found'. |
We've hit a bit of a roadblock here. Apparently Mozilla has now banned the use of Angular 1.x outright, which is a core library of our extension. I was not aware of this until just now. I have raised an issue with Mozilla and it is being tracked here: mozilla/addons-linter#1000 Stay tuned. |
Good news. Angular has resolved the issue that has been holding us back. They plan to release v1.5.9 of angular soon. Whenever that happens we will quickly upgrade and re-submit to Mozilla for review. |
Though it looks like in the linter discussion mozilla is still not satisfied with the checks in v1.5.9... But it looks like the angular team and Mozilla are working together to resolve it? |
I believe that their linter will require an update to block v1.5.9 which means it will require no change on their end and we can resubmit as soon as v1.5.9 lands. |
As of v1.5.0, we are now in review with Mozilla again. We are working on trying to reduce the wait time of the review process. |
When you try to install the version V1.50 (link first posting) you get an error that this extension doe sot work in FF 43 or higher. |
I believe that's because Mozilla hasn't signed the add-on since it's still in review? And users in regular versions of Firefox can't disable the code signing check, so bitwarden doesn't have much power here other than to wait for the review to finish. Or convince it's users to use the nightly edition of Firefox, with all of that potential instability. |
If that is the reason I understand it. But strange for something like FF there is no setting somewhere, like by means of an about:config setting, to override that. And why can you install it in FF 42? It should be all or nothing. |
As mentioned, Mozilla requires that the extension be reviewed and signed before you can add it from their store. There is nothing we can really do about it. The wait time for their review process on new addons is months. We are in the queue at position 208 of 306 :( . The only option to use the extension in the meantime is to build the source and add it locally via |
@kspearrin about Opera; |
Regarding Opera, we have had our extension in their review queue for 3 months now and there is no response. New addons for Opera seem to be dead since noone is reviewing new submissions there anymore. The good news is that Opera and Chrome Web Store extensions are compatible -- meaning you can install bitwarden from the Chrome web store by using this opera extension: https://addons.opera.com/en/extensions/details/download-chrome-extension-9/ I will need to put together a help article to link to from the homepage Opera icon. |
Hi there, I ve installed Bitwarden from Chrome store with this extension https://addons.mozilla.org/en-US/firefox/addon/chrome-store-foxified/?src=search This could a temporaly solution (It`s working fine, but I dont know if exist some problem with security, please check it) Sorry for my english Im spanish guy. Cheers |
@Zorroblanco thank you. It is complicated and inconvenient but at least it works. Thanks again. |
Dec 22 |
Then we can expect a review at the end of January... |
Dec 27 |
Dec 30 - 113 of 327 |
Thanks Kyle for keeping us informed of the Firefox queue progress. Can't wait to use this add-on. |
Jan 1 |
Jan 6 |
Jan 11 |
Jan 16 |
We are out of the queue and in active review. Expect release soon! |
Another extension which I'm using 'bypasses' the Firefox review queues by providing a GreaseMonkey script. Would that be something sensible for you to do, too ? I mean, saying a hotfix is needed and as a user you have to wait until the queue clears, I'd prefer to get an unsigned version on GreaseMonkey, because I have to trust you anyways. |
Such a long waiting time does not seem to be that common: https://blog.mozilla.org/addons/2017/02/14/add-ons-update-92 |
Mozilla relies heavily on community members to review addons. Apparently since our addon is not a simple one, and contains a lot of code the community reviewers will not review it. Therefore, our addon falls into a bucket of only a select few official Mozilla employees (one that I know of) that review addons. Reviewing addons is not their only job, so we're stuck waiting for them to have some time in order to decide to start reviewing it. This was the explanation I was given by Mozilla during all my emails to them about this. Sad that we have to wait so long. We're at their mercy at this point :( |
We moved a tick. Queue Position: 4 of 298 |
I suspect the "is corrupt" message is due to the following log entries I see on current Nightlies:
IIUC, https://github.com/bitwarden/browser/blob/master/src/manifest.json doesn't specify an ID for this addon? It does appear to load from about:debugging though. |
@mhammond The corrupt message is simply because Mozilla hasn't reviewed it yet. |
Guys when we can expect this extension, what is the current status? |
Please refer to the updates above. |
@kspearrin I'm confident the issue isn't simply that it hasn't been reviewed, so I took your addon, unzipped it, added:
to manifest.json, re-packed it, and I could install the addon fine. I'm fairly sure that will only work on Nightly and Aurora with the preference xpinstall.signatures.required set to false, but in that environment it's certainly possible to manually install your own unsigned addons and have them work. I suspect about:debugging generates an ID for you (and it may even be possible that the repacked xpi of the signed addon that will end up on addons.mozilla.org will also have an ID assigned for you), but it's certainly true that the lack of the ID in the XPI pointed at above is preventing it from being installed in Nightly and Aurora with the "must be signed" preference set to false.. |
@mhammond According to this: https://wiki.mozilla.org/Add-ons/Extension_Signing
Are you saying that this is not necessarily the case? |
According to the above, |
The above is for the release and beta channels only - Nightly and Aurora (aka Dev Edition) does still allow it. So while that doesn't help the vast majority of users, it probably does help unstick developers and gives an option for your "early adopters". |
Looks like an ID has already been assigned by AMO and I cannot change it at this point (without abandoning my current submission and starting over).
|
Can you just use the ID assigned by AMO? I don't think the ID is exposed via any UI, so it doesn't really matter what it is. |
Give it a try now from the AMO listing. I don't get the corrupt error anymore, now just a signing error. |
On a current Nightly with |
@mhammond Great! I see you are part of the Mozilla Org. Do you happen to pull any weight there in the Firefox addons department? We've been patiently waiting for our extension to be listed since September. This whole process has been painful. I'm a Firefox user myself and I've had to basically abandon it for the past 6 months in favor of Chrome because of this. |
I'm afraid I don't carry any weight in addons :( I did however raise this in our internal forums and made the exact same point as you - ie, "5 months in review, during which there are 6.5k chrome users of the addon - surely this is hurting us!" and I'll continue to agitate where I can. |
I can't tell you how many emails I get every week about "when will it be available on Firefox?" :-( |
@Anaithsol please open a separate issue. |
Finally extension reviewed by Mozilla and available to install but panel is blank if using in "Private Mode" is this only me? |
Finally! After 155 days of waiting, the extension has been reviewed by Mozilla and available on Firefox now here: https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager Thank you all for your patience. I'm sorry it took so long but there wasn't a hole lot we could do differently here. If you have any problems, please open them as separate issues. |
Additionally, since we're so behind in Firefox now, if you all enjoy the extension there, please consider leaving us a good review in the addons store. It helps a lot!! |
@kspearrin This won't work in Private Mode? |
@umarmughal This is due to a bug with Firefox that Mozilla is working on fixing. See here: https://bugzilla.mozilla.org/show_bug.cgi?id=1319452 There's nothing we can do about it at this time. |
Note that https://bitwarden.com/ still indicates the addon is in review - it should probably be changed to the AMO link. |
Fixed in all places exception the web vault. Not ready to do a release there yet. |
- The * mask has the potential to leak the users password length and should not be used. Fixes #8
* feature/cli-18-import * updates to jslib
The Firefox extension was submitted to Mozilla on Sept 23rd and is currently in review. It seems that the review process for Firefox is a much longer wait time (compared to Chrome, which is nearly instant) since they rely on volunteers for this code review process. There is an indicator on their developer site that shows what position you are in line for review. We started on Sept 23rd @ queue position 111 of 111. I will follow up in this thread with the status.
https://addons.mozilla.org/en-US/firefox/addon/bitwarden-password-manager/
The text was updated successfully, but these errors were encountered: