Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Prettier #2238

Merged
merged 10 commits into from Dec 21, 2021
Merged

Apply Prettier #2238

merged 10 commits into from Dec 21, 2021

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Dec 20, 2021

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Sync existing branches:

  1. Check out your local Branch
  2. Run git merge
  3. Resolve any merge conflicts, commit.
  4. Run npm prettier
  5. Commit
  6. Run git merge -Xours
  7. Push

Testing requirements

N/A Should be no functional changes

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

djsmith85
djsmith85 previously approved these changes Dec 21, 2021
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

We excluded autofill.js (should remain as is) and the src/services/autofill.service.ts.
I plan on doing some refactoring/cleanup on src/services/autofill.service.ts before running prettier on it again.

Create Tech-Debt task: https://app.asana.com/0/1201461753012676/1201545171857430/f in Asana.

Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now

@Hinton Hinton merged commit 8fe821b into master Dec 21, 2021
@Hinton Hinton deleted the feature/prettier-apply branch December 21, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants