Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC-183] Move eslint and prettier to project root #2536

Merged
merged 10 commits into from May 3, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented May 3, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Brings back the husky pre-commit hook, and moves the eslint and prettier configs to the project root.

Also solved a pipeline issue where paths omitted /** causing them to not run.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@vgrassia vgrassia self-requested a review May 3, 2022 19:18
vgrassia
vgrassia previously approved these changes May 3, 2022
Copy link
Member

@vgrassia vgrassia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for workflow changes.

@Hinton Hinton force-pushed the feature/move-eslint-root branch from ab837b2 to 0057451 Compare May 3, 2022 19:24
@Hinton Hinton requested review from vgrassia and a team May 3, 2022 19:28
@Hinton Hinton merged commit c1cc5a0 into master May 3, 2022
@Hinton Hinton deleted the feature/move-eslint-root branch May 3, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants