Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS-1198] Desktop / Browser: Accessibility - make TOTP countdown announce for assistive technology users #2660

Merged
merged 19 commits into from
Oct 3, 2022
Merged

[PS-1198] Desktop / Browser: Accessibility - make TOTP countdown announce for assistive technology users #2660

merged 19 commits into from
Oct 3, 2022

Commits on May 8, 2022

  1. Make totp countdown aria-hidden, add copy of countdown as sr-only… 

    … inside totp button, only make it conditionally "exist" on parent focus
    @patrickhlauke
    patrickhlauke committed May 8, 2022
    Configuration menu
    Copy the full SHA
    c71f441 View commit details
    Browse the repository at this point in the history

  2. Make exact same changes to desktop totp

    @patrickhlauke
    patrickhlauke committed May 8, 2022
    Configuration menu
    Copy the full SHA
    05213cb View commit details
    Browse the repository at this point in the history

  3. Tweak copy button accessible name approach 

    instead of `aria-label`, which overrides the content of the button and, because JAWS has trouble announcing the live region in the desktop app, results in JAWS not announcing ANY countdown at all, this at least announces the current countdown number when the button receives focus in JAWS
    @patrickhlauke
    patrickhlauke committed May 8, 2022
    Configuration menu
    Copy the full SHA
    5a91097 View commit details
    Browse the repository at this point in the history

  4. Add aria-atomic="true" 

    avoid JAWS/Firefox only announcing the specific digit that updates, rather than the number as a whole
    @patrickhlauke
    patrickhlauke committed May 8, 2022
    Configuration menu
    Copy the full SHA
    2f8c09c View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ebd35ff View commit details
    Browse the repository at this point in the history

  2. Update, run prettier, lint

    @patrickhlauke
    patrickhlauke committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    10b6804 View commit details
    Browse the repository at this point in the history

  3. Remove orphaned jslibs

    @patrickhlauke
    patrickhlauke committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    6af2a1e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    e6e840a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e520042 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2924ad4 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    c2fed81 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    544fbef View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    6be3657 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    2fbdb8a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    ab46ba6 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    084d60d View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c135f87 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @djsmith85
    djsmith85 committed Sep 25, 2022
    Configuration menu
    Copy the full SHA
    6ca1781 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Merge branch 'master' into patrickhlauke-issue2657

    @patrickhlauke
    patrickhlauke committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    7ac6531 View commit details
    Browse the repository at this point in the history