Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL-7] Avatar #3153

Merged
merged 35 commits into from Sep 6, 2022
Merged

[CL-7] Avatar #3153

merged 35 commits into from Sep 6, 2022
+238 −42

Conversation

rr-bw
Copy link
Contributor

@rr-bw rr-bw commented Jul 21, 2022 •
edited

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

- [X] I have checked for **linting** errors (`npm run lint`) (required)
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

@rr-bw rr-bw changed the title CL-7 Avatar [CL-7] Avatar Jul 21, 2022
Hinton
Hinton requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets take this opportunity to clean up the component and remove most of the legacy logic.

libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
libs/components/src/avatar/avatar.component.ts Outdated Show resolved Hide resolved
@rr-bw rr-bw requested a review from Hinton July 27, 2022 20:33
@rr-bw rr-bw requested a review from Hinton August 10, 2022 19:44
vincentsalucci
vincentsalucci previously approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@vincentsalucci vincentsalucci left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! @Hinton @danielleflinn will have the final approvals 👍
(@rr-bw this will need another merge from master, however)

@danielleflinn
Copy link
Member

Looks good to me too. Thanks all

Hinton
Hinton reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me except for that outdated comment. Thanks for iterating on this @rr-bw.

vincentsalucci
vincentsalucci previously approved these changes Aug 24, 2022
View reviewed changes
danielleflinn
danielleflinn previously approved these changes Aug 24, 2022
View reviewed changes
Hinton
Hinton previously approved these changes Aug 25, 2022
View reviewed changes
@rr-bw rr-bw merged commit 7c5e4dd into master Sep 6, 2022
@rr-bw rr-bw deleted the CL-7-avatar branch September 6, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

@vincentsalucci vincentsalucci vincentsalucci left review comments

@danielleflinn danielleflinn danielleflinn left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rr-bw @Hinton @danielleflinn @vincentsalucci