Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sm-144] Move SharedModule to root #3222

Closed
wants to merge 5 commits into from
Closed

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Aug 2, 2022

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Part of the https://adr.bitwarden.com/decisions/0011-angular-folder-structure. Moves the SharedModule from modules directory to shared/shared.module.ts. The goal is to have each module in the application inherit this shared module which provides some common bootstrapping.

Before you submit

- [ ] I have checked for **linting** errors (`npm run lint`) (required)
- [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required)
- [ ] This change requires a **documentation update** (notify the documentation team)
- [ ] This change has particular **deployment requirements** (notify the DevOps team)

@Hinton Hinton requested a review from addisonbeck August 2, 2022 17:28
@Hinton Hinton changed the title Move SharedModule to root [sm-144] Move SharedModule to root Aug 2, 2022
@Hinton
Copy link
Member Author

Hinton commented Aug 3, 2022

Superseded by #3225. Relevant commits have been cherry picked.

@Hinton Hinton closed this Aug 3, 2022
@Hinton Hinton deleted the feature/shared-module branch September 29, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant