Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build errors for strict templates #4134

Merged
merged 1 commit into from Nov 28, 2022
Merged

Fix build errors for strict templates #4134

merged 1 commit into from Nov 28, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Nov 28, 2022

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes build errors caused by #3601

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@Hinton Hinton requested a review from eliykat November 28, 2022 22:06
@eliykat eliykat merged commit 1686c3b into master Nov 28, 2022
@eliykat eliykat deleted the hotfix/strict-templates branch November 28, 2022 23:00
rr-bw pushed a commit that referenced this pull request Jan 10, 2023
@Hinton @rr-bw
Fix build errors for strict templates (#4134)
1034549
cyprain-okeke pushed a commit that referenced this pull request Jan 11, 2023
@Hinton @cyprain-okeke
Fix build errors for strict templates (#4134)
14c9108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliykat eliykat eliykat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hinton @eliykat