Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null value URLs in autofiller script #4277

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Handle null value URLs in autofiller script #4277

merged 1 commit into from
Dec 28, 2022

Conversation

MGibson1
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

It is possible to store null URIs for cipher items, if this occurs, the autofill script throws when trying to index the protocol of the uri. Fix is to null check URIs here.

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@MGibson1 MGibson1 requested a review from a team December 20, 2022 12:06
@MGibson1 MGibson1 added the needs-qa Marks a PR as requiring QA approval label Dec 20, 2022
@MGibson1 MGibson1 removed the needs-qa Marks a PR as requiring QA approval label Dec 28, 2022
@MGibson1
Copy link
Member Author

QA approved

@MGibson1 MGibson1 merged commit c10e93c into master Dec 28, 2022
@MGibson1 MGibson1 deleted the ps/ps-2089-blank-uri branch December 28, 2022 14:49
@djsmith85 djsmith85 mentioned this pull request Jan 9, 2023
Closed
rr-bw pushed a commit that referenced this pull request Jan 10, 2023
@MGibson1 @rr-bw
Handle null value URLs in autofiller script (#4277)
437aed2
rr-bw pushed a commit that referenced this pull request Jan 10, 2023
@MGibson1 @rr-bw
Handle null value URLs in autofiller script (#4277)
cee06e3
cyprain-okeke pushed a commit that referenced this pull request Jan 11, 2023
@MGibson1 @cyprain-okeke
Handle null value URLs in autofiller script (#4277)
3e22ce9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsmith85 djsmith85 djsmith85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MGibson1 @djsmith85