[PM-4108] Add "twoFa" to the TotpFieldNames array in autofill-constants.ts #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add "twoFa" to the TotpFieldNames constant
|
|
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
jprusik
approved these changes
Oct 3, 2023
|
Thanks again for your contribution @pejeio - the changes have passed QA and have been merged. |
jprusik
added a commit
that referenced
this pull request
Nov 14, 2023
"approvals_code", -- facebook.com "code", -- cash.app, docker.com, dropbox.com, evernote.com, lincolnfinancial.com, "otc", -- live.com "otc-code", -- evernote.com "otp-code", -- getpostman.com "otpcode", -- amazon.com "pin", -- linkedin.com "security_code", -- docusign.com "twofa", -- #6413 (but lowercased to match convention) "verificationCode", -- bestbuy.com Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
BlackDex
pushed a commit
to BlackDex/bitwarden-clients
that referenced
this pull request
Nov 21, 2023
…ts.ts (bitwarden#6413) * Update autofill-constants.ts add "twoFa" to the TotpFieldNames constant * add "twoFa" to the TotpFieldNames array in autofill-constants.ts
BlackDex
pushed a commit
to BlackDex/bitwarden-clients
that referenced
this pull request
Nov 21, 2023
"approvals_code", -- facebook.com "code", -- cash.app, docker.com, dropbox.com, evernote.com, lincolnfinancial.com, "otc", -- live.com "otc-code", -- evernote.com "otp-code", -- getpostman.com "otpcode", -- amazon.com "pin", -- linkedin.com "security_code", -- docusign.com "twofa", -- bitwarden#6413 (but lowercased to match convention) "verificationCode", -- bestbuy.com Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
quexten
pushed a commit
to quexten/clients
that referenced
this pull request
Feb 10, 2024
…ts.ts (bitwarden#6413) * Update autofill-constants.ts add "twoFa" to the TotpFieldNames constant * add "twoFa" to the TotpFieldNames array in autofill-constants.ts
quexten
pushed a commit
to quexten/clients
that referenced
this pull request
Feb 10, 2024
"approvals_code", -- facebook.com "code", -- cash.app, docker.com, dropbox.com, evernote.com, lincolnfinancial.com, "otc", -- live.com "otc-code", -- evernote.com "otp-code", -- getpostman.com "otpcode", -- amazon.com "pin", -- linkedin.com "security_code", -- docusign.com "twofa", -- bitwarden#6413 (but lowercased to match convention) "verificationCode", -- bestbuy.com Co-authored-by: Jonathan Prusik <jprusik@classynemesis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Improvement of TOTP field recognition. This change adds
"twoFa"to theTotpFieldNamesarray in apps/browser/src/autofill/services/autofill-constants.ts.Many websites now use
"twoFa"as an ID for their TOTP text input fields. By including it in theTotpFieldNamesarray, Bitwarden will be better equipped to identify and autofill these fields, enhancing the user experience for a wide range of websites.