Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEVOPS-1572] Update JS workflows to Node version 18 #6421

Merged

Conversation

michalchecinski
Copy link
Contributor

@michalchecinski michalchecinski commented Sep 27, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [x] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Pull the node version from the .nvmrc file and use it in every setup-node action.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@michalchecinski michalchecinski requested a review from a team as a code owner September 27, 2023 12:21
@bitwarden-bot
Copy link

bitwarden-bot commented Sep 27, 2023

Logo
Checkmarx One – Scan Summary & Details2ff9884e-348c-438a-ba3a-a66b3b2871ce

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 60 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 58 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 61 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 37 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 30 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/safeincloud-xml-importer.ts: 24 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/keepass2-xml-importer.ts: 23 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/clipperz-html-importer.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/passwordsafe-xml-importer.ts: 17 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/src/importers/passky/passky-json-importer.ts: 22 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/common/src/vault/services/cipher.service.ts: 132 Attack Vector

Fixed Issues

Severity Issue Source File / Package
LOW Use_Of_Hardcoded_Password /libs/common/src/vault/services/cipher.service.ts: 998

@michalchecinski michalchecinski merged commit 65e698b into master Oct 4, 2023
49 checks passed
@michalchecinski michalchecinski deleted the DEVOPS-1572-Update-our-JS-workflows-to-Node-version-18 branch October 4, 2023 16:23
BlackDex pushed a commit to BlackDex/bitwarden-clients that referenced this pull request Nov 21, 2023
* Get node version from .nvmrc and use in setup-node action

* Fix substitution

* Fix substitution 2

* Fix substitution 3

* Add ls

* Add ls

* Override working directory

* Fix override working directory

* Fix

* Add ls

* Checkout repo
quexten pushed a commit to quexten/clients that referenced this pull request Feb 10, 2024
* Get node version from .nvmrc and use in setup-node action

* Fix substitution

* Fix substitution 2

* Fix substitution 3

* Add ls

* Add ls

* Override working directory

* Fix override working directory

* Fix

* Add ls

* Checkout repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants