Vault Timeout Service Tests & Bug Fix #7021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGibson1
approved these changes
Nov 29, 2023
| expectNoAction("2"); | ||
| }); | ||
|
|
||
| it("should run action on an account that hasn't been active for greater than 1 minute and has a vault timeout for 1 minutes", async () => { |
There was a problem hiding this comment.
nit: I prefer single assert tests, which would make this test a describe block with four tests in it
jlf0dev
pushed a commit
that referenced
this pull request
Nov 30, 2023
* Add Tests to VaultTimeoutService * Fix Bug Get availableTimeoutActions for the user actually locking instead of getting the timeout actions for the active user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
While working on a different ticket I started working on tests for VaultSettingsService and noticed a bug while writing the tests. The other ticket may not be completed as quickly so I decided to make a PR for these items instead of waiting for the other work.
Helps with PM-4996
Code changes
Screenshots
Before you submit