[PM-5177] fix CLI list items lock error

[bxb100]

Type of change

• Bug fix
• New feature development
• Tech debt (refactoring, code cleanup, dependency upgrades, etc)
• Build/deploy pipeline (DevOps)
• Other

Objective

fix #7126

Code changes

apps/cli/src/commands/list.command.ts: sync run this.eventCollectionService.collect

the execution stack is:

clients/libs/common/src/services/event/event-collection.service.ts

Line 36 in 77c54c2

const cipher = await this.cipherService.get(cipherId);

clients/libs/common/src/vault/services/cipher.service.ts

Lines 262 to 263 in 77c54c2

	async get(id: string): Promise<Cipher> {
	const ciphers = await this.stateService.getEncryptedCiphers();

clients/libs/common/src/platform/services/state.service.ts

Line 1751 in 77c54c2

await this.getAccount(this.reconcileOptions(options, await this.defaultOnDiskMemoryOptions()))

clients/libs/common/src/platform/services/state.service.ts

Line 3011 in 77c54c2

: await this.storageService.get<TAccount>(options.userId, options);

clients/apps/cli/src/platform/services/lowdb-storage.service.ts

Line 118 in 77c54c2

return this.lockDbFile(() => {

obviously proper-lockfile lock showed the error is typically lock race

Screenshots

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-5177

[CLAassistant]

All committers have signed the CLA.

[bitwarden-bot]

Checkmarx One – Scan Summary & Details – c8a3cac0-7ec9-4c24-a04a-bf0b5dab9283

No New Or Fixed Issues Found

[ttalty]

This fixes the issue on the lock file being held.

[ttalty]

Thank you for the contribution! This PR has been approved and is moving to QA for testing.

[Geezus42]

When will the release be cut? I've already delt with a broken work flow for a week, is it going to be two? It's not a good sign that this was not caught by your QA.

[jabofh]

Since I'm still struggling with this issue, have you any idea when it'll be generally available?

❯ macosver
10.16
❯
❯ ./bw --version
2024.2.0
❯ 
❯ time ./bw list items --session "$( cat ~/.bw_session )" > /dev/null
./bw list items --session "$( cat ~/.bw_session )" > /dev/null  75.39s user 18.67s system 151% cpu 1:02.10 total
❯ 

Still not the less-than-30-seconds it takes on my Fedora box...

eroux@fedoravm:~$ time bw list items --session "$( cat ~/.bw_session )" > /dev/null

real	0m23.664s
user	0m19.311s
sys	0m5.879s
eroux@fedoravm:~$ 

[bxb100]

@jabofh you may need to check lowdb/adapters/FileSync how to prolong the execution