-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields for LDLC #729
Add fields for LDLC #729
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -418,7 +418,7 @@ export default class AutofillService implements AutofillServiceInterface { | |
// ref https://developers.google.com/web/fundamentals/design-and-ux/input/forms/ | ||
if (!fillFields.cardholderName && this.isFieldMatch(f[attr], | ||
['cc-name', 'card-name', 'cardholder-name', 'cardholder', 'name', 'nom'], | ||
['cc-name', 'card-name', 'cardholder-name', 'cardholder'])) { | ||
['cc-name', 'card-name', 'cardholder-name', 'cardholder', 'tbName'])) { | ||
fillFields.cardholderName = f; | ||
break; | ||
} else if (!fillFields.number && this.isFieldMatch(f[attr], | ||
|
@@ -444,7 +444,7 @@ export default class AutofillService implements AutofillServiceInterface { | |
'expire-month', 'expire-mo', 'expiry-month', 'expiry-mo', 'card-expire-month', | ||
'card-expire-mo', 'card-expiry-month', 'card-expiry-mo', 'mois-validite', | ||
'mois-expiration', 'm-validite', 'm-expiration', 'expiry-date-field-month', | ||
'expiration-date-month', 'expiration-date-mm', 'exp-mon'])) { | ||
'expiration-date-month', 'expiration-date-mm', 'exp-mon', 'ddValidityMonth'])) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. make it more generic: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, same as for other fields : the exact name is very long. |
||
fillFields.expMonth = f; | ||
break; | ||
} else if (!fillFields.expYear && this.isFieldMatch(f[attr], | ||
|
@@ -455,12 +455,12 @@ export default class AutofillService implements AutofillServiceInterface { | |
'expiry-year', 'expiry-yr', 'card-expire-year', 'card-expire-yr', 'card-expiry-year', | ||
'card-expiry-yr', 'an-validite', 'an-expiration', 'annee-validite', | ||
'annee-expiration', 'expiry-date-field-year', 'expiration-date-year', | ||
'expiration-date-yy', 'expiration-date-yyyy'])) { | ||
'expiration-date-yy', 'expiration-date-yyyy', 'ddlValidityYear'])) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree |
||
fillFields.expYear = f; | ||
break; | ||
} else if (!fillFields.code && this.isFieldMatch(f[attr], | ||
['cvv', 'cvc', 'cvv2', 'cc-csc', 'cc-cvv', 'card-csc', 'card-cvv', 'cvd', 'cid', 'cvc2', 'cnv', | ||
'cvn2', 'cc-code', 'card-code', 'code-securite', 'security-code'])) { | ||
'cvn2', 'cc-code', 'card-code', 'code-securite', 'security-code', 'tbCrypto'])) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
fillFields.code = f; | ||
break; | ||
} else if (!fillFields.brand && this.isFieldMatch(f[attr], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should already be handled by the "name" contains check right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the exact field name is very long and this is the only relevant part.