Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5663] Fix copy to clipboard not working on Wayland #7508

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

amarshall
Copy link
Contributor

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

See #6812.

Confirmed issue is still present without this change. Confirmed works on Wayland and X11 (via XWayland) using Sway WM, with this change. No testing performed on other platforms.

Code changes

@amarshall amarshall requested a review from a team as a code owner January 10, 2024 17:13
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-5663

@bitwarden-bot bitwarden-bot changed the title Fix copy to clipboard not working on Wayland [PM-5663] Fix copy to clipboard not working on Wayland Jan 10, 2024
@djsmith85 djsmith85 linked an issue Jan 15, 2024 that may be closed by this pull request
1 task
@AkechiShiro
Copy link

AkechiShiro commented Jan 21, 2024

This is a pretty important issue in my opinion, this PR should be reviewed and tested, a password manager that cannot copy password, feels pretty useless. @jprusik

@dani-garcia dani-garcia self-assigned this Jan 22, 2024
@dani-garcia dani-garcia added the needs-qa Marks a PR as requiring QA approval label Jan 22, 2024
@dani-garcia
Copy link
Member

Hey @amarshall! Thanks for this PR, everything looks good code wise, I've forwarded this PR to QA for testing, once that's done it should be ready to merge soon.

@dani-garcia dani-garcia removed the needs-qa Marks a PR as requiring QA approval label Feb 12, 2024
@dani-garcia
Copy link
Member

Sorry for the delay, this has gone through QA and will be merged now, it should be available in the next release (2024.3.0). Thanks again for the PR @amarshall!

@dani-garcia dani-garcia merged commit 746bf0a into bitwarden:main Feb 12, 2024
60 of 68 checks passed
@amarshall amarshall deleted the wayland-clipboard branch March 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying to clipboard is broken on Wayland
5 participants