Move key types to central location #7531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7531 +/- ##
=======================================
Coverage 63.01% 63.01%
=======================================
Files 760 760
Lines 21525 21525
Branches 4272 4272
=======================================
Hits 13563 13563
Misses 7140 7140
Partials 822 822 ☔ View full report in Codecov by Sentry. |
|
@MGibson1 , this is a great change, but looks like there are several build failures to address still. |
MGibson1
force-pushed
the
ps/move-key-types-to-central-location
branch
2 times, most recently
from
3954a2b
to
812ff95
Compare
MGibson1
force-pushed
the
ps/move-key-types-to-central-location
branch
from
812ff95
to
ce9b3ec
Compare
djsmith85
previously approved these changes
Jan 15, 2024
Hinton
previously approved these changes
Jan 16, 2024
justindbaur
reviewed
Jan 16, 2024
libs/common/src/types/key.d.ts
Outdated
There was a problem hiding this comment.
Why a .d.ts file? TypeScript maintainers aren't a fan of using them for this. microsoft/TypeScript#52593 (comment)
There was a problem hiding this comment.
didn't know that, I'd always thought they were indicators of types only
Jingo88
previously approved these changes
Jan 16, 2024
cturnbull-bitwarden
previously approved these changes
Jan 16, 2024
cagonzalezcs
previously approved these changes
Jan 16, 2024
shane-melton
previously approved these changes
Jan 16, 2024
MGibson1
dismissed stale reviews from cagonzalezcs, cturnbull-bitwarden, Jingo88, Hinton, JaredSnider-Bitwarden, and djsmith85
via
a407aa4
MGibson1
requested review from
justindbaur,
Hinton,
Jingo88,
cturnbull-bitwarden,
JaredSnider-Bitwarden,
cagonzalezcs,
shane-melton and
djsmith85
shane-melton
approved these changes
Jan 16, 2024
cagonzalezcs
approved these changes
Jan 16, 2024
justindbaur
approved these changes
Jan 16, 2024
JaredSnider-Bitwarden
approved these changes
Jan 16, 2024
eliykat
approved these changes
Jan 16, 2024
djsmith85
approved these changes
Jan 17, 2024
cturnbull-bitwarden
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Moves key types to a central type file. I plan on expanding these opaque types to include asymmetric keys, which make sense in a single key type file rather than distributed between multiple.
All changes are either moving these opaque types or import updates.
Before you submit